public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Paul Jackson <pj@sgi.com>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
	bert.wesarg@googlemail.com, mingo@elte.hu,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] Fix calculus of bitmap_scnprintf_len()
Date: Mon, 28 Apr 2008 10:09:17 -0700	[thread overview]
Message-ID: <481604BD.7000009@sgi.com> (raw)
In-Reply-To: <20080428081326.fc62f1ce.pj@sgi.com>

Paul Jackson wrote:
> Bert wrote:
>> The function bitmap_scnprintf_len() is currently not used
> 
> Paul Jackson wrote:
>> How about we just remove that function?
> 
> WANG Cong wrote:
>> I am afraid no. See:
>>
>> include/linux/cpumask.h:292:    return bitmap_scnprintf_len(len);
> 
> Good point.
> 
> 
> Then how about we also remove from cpumask.h:
> 
> #define cpumask_scnprintf_len(len) \
>                         __cpumask_scnprintf_len((len))
> static inline int __cpumask_scnprintf_len(int len)
> {
>         return bitmap_scnprintf_len(len);
> }
> 

That's fine with me.  A later version of the patch did have
the function removed but it didn't get picked up.  The other
changes there were to use function pointers instead of the
flag variable to select list or mask output format, and the
addition of mask variants for the cpu/{present,possible,
online,system} map outputs.

I'll dig that one back up and resubmit it.

Thanks,
Mike

  reply	other threads:[~2008-04-28 17:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27 20:43 [PATCH] Fix calculus of bitmap_scnprintf_len() Bert Wesarg
2008-04-27 21:01 ` Paul Jackson
2008-04-28  6:14   ` WANG Cong
2008-04-28 13:13     ` Paul Jackson
2008-04-28 17:09       ` Mike Travis [this message]
2008-04-28 17:31         ` Bert Wesarg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481604BD.7000009@sgi.com \
    --to=travis@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=bert.wesarg@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pj@sgi.com \
    --cc=torvalds@linux-foundation.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox