From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S937399AbYD1UmT@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S937399AbYD1UmT (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Apr 2008 16:42:19 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933008AbYD1UmF
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 28 Apr 2008 16:42:05 -0400
Received: from smtpq2.groni1.gr.home.nl ([213.51.130.201]:47366 "EHLO
	smtpq2.groni1.gr.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1765500AbYD1UmD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Apr 2008 16:42:03 -0400
Message-ID: <4816368A.1070100@keyaccess.nl>
Date: Mon, 28 Apr 2008 22:41:46 +0200
From: Rene Herman <rene.herman@keyaccess.nl>
User-Agent: Thunderbird 2.0.0.12 (X11/20080213)
MIME-Version: 1.0
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
CC: Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
       linux-kernel@vger.kernel.org, Adam Belay <ambx1@neo.rr.com>,
       Adam M Belay <abelay@mit.edu>, Li Shaohua <shaohua.li@intel.com>,
       Matthieu Castet <castet.matthieu@free.fr>,
       Thomas Renninger <trenn@suse.de>, Jaroslav Kysela <perex@perex.cz>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 41/54] PNP: remove pnp_resource_table references from
 resource decoders
References: <20080425183807.366134771@ldl.fc.hp.com> <20080425183932.457629051@ldl.fc.hp.com> <4813AC7D.9000006@keyaccess.nl> <200804281436.21061.bjorn.helgaas@hp.com>
In-Reply-To: <200804281436.21061.bjorn.helgaas@hp.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -1.0 (-)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28-04-08 22:36, Bjorn Helgaas wrote:
> On Saturday 26 April 2008 04:28:13 pm Rene Herman wrote:
>> On 25-04-08 20:38, Bjorn Helgaas wrote:
>>
>>> Index: work10/drivers/pnp/pnpacpi/rsparser.c
>>> ===================================================================
>>> --- work10.orig/drivers/pnp/pnpacpi/rsparser.c	2008-04-25 11:15:08.000000000 -0600
>>> +++ work10/drivers/pnp/pnpacpi/rsparser.c	2008-04-25 11:15:09.000000000 -0600
>>> @@ -82,8 +82,8 @@
>>>  						u32 gsi, int triggering,
>>>  						int polarity, int shareable)
>>>  {
>>> -	struct pnp_resource_table *res = dev->res;
>>> -	int i = 0;
>>> +	struct resource *res;
>>> +	int i;
>>>  	int irq;
>>>  	int p, t;
>>>  	static unsigned char warned;
>>> @@ -91,9 +91,11 @@
>>>  	if (!valid_IRQ(gsi))
>>>  		return;
>>>  
>>> -	while (!(res->irq_resource[i].flags & IORESOURCE_UNSET) &&
>>> -	       i < PNP_MAX_IRQ)
>>> -		i++;
>>> +	for (i = 0; i < PNP_MAX_IRQ; i++) {
>>> +		res = &dev->res->irq_resource[i];
>>> +		if (res->flags & IORESOURCE_UNSET)
>>> +			break;
>>> +	}
>> Another possible user of pnp_resource_valid.
> 
> I changed this, and also changed the array lookups to use
> pnp_get_resource().  And I made similar changes in ISAPNP.
> 
> And I replaced many of these &dev->res->irq_resource[] things
> with pnp_get_resource().  This change rippled through several
> subsequent patches, but it's just more mechanical changes.

Great. If you can do the same thing as previously, and leave out / remove my 
Acked-By from the ones that changed so that I can easily identify them, I'll 
  go over the remaining ones (tomorrow, probably).

Rene.