public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: David Newall <davidn@davidnewall.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	Markus Metzger <markus.t.metzger@intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: DS cleanup - dont treat 0 as NULL
Date: Mon, 28 Apr 2008 23:38:16 -0700	[thread overview]
Message-ID: <4816C258.7050203@zytor.com> (raw)
In-Reply-To: <4816BEC8.1080708@davidnewall.com>

David Newall wrote:
> Cyrill Gorcunov wrote:
>> -			return 0;
>> +			return NULL;
> 
> Why?  The constant 0 is C's official symbol for a null pointer.

It's still bad style.

	-hpa

  reply	other threads:[~2008-04-29  6:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28 19:15 [PATCH] x86: DS cleanup - dont treat 0 as NULL Cyrill Gorcunov
2008-04-28 19:45 ` H. Peter Anvin
2008-04-28 19:46 ` H. Peter Anvin
2008-04-28 20:00   ` Cyrill Gorcunov
2008-04-28 20:02 ` Ingo Molnar
2008-04-29  6:23 ` David Newall
2008-04-29  6:38   ` H. Peter Anvin [this message]
2008-04-29 17:30     ` David Newall
2008-04-29  7:50   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4816C258.7050203@zytor.com \
    --to=hpa@zytor.com \
    --cc=davidn@davidnewall.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@intel.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox