Re: [PATCH v2 11/31] x86/virt/tdx: Make TDX Module initialize Extensions

Huang, Kai
2026-04-09T01:29:23Z

On Thu, 2026-04-09 at 00:49 +0000, Edgecombe, Rick P wrote:
> On Wed, 2026-04-08 at 21:24 +0000, Huang, Kai wrote:
> > I don't think we need to guess here.  We need to understand what the
> > architecture behaviour is and then write code based on that.  If
> > there's anything not clear on architecture, we need to ask the module
> > team to clarify.
>
> A general comment...I think this is the wrong attitude. If we have some
> assumptions that can simplify the kernel code, let's get them in the
> spec. Or otherwise get an agreement from the TDX module to make them no
> longer assumptions.
>
> Just silently hoping our assumptions are true is not great either. But
> uncritically implementing the architecture that is handed down is
> totally wrong.

Yes agree in principle.

Maybe I am missing something, but I don't see any big issue for this
particular architecture behaviour. If you have any good idea to improve
this flow then great.