From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751649AbcBKQdZ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Feb 2016 11:33:25 -0500
Received: from mout.kundenserver.de ([212.227.126.131]:57153 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750992AbcBKQdX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Feb 2016 11:33:23 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sascha Hauer <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org,
        Jiri Slaby <jslaby@suse.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Eddie Huang <eddie.huang@mediatek.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m
Date: Thu, 11 Feb 2016 17:31:56 +0100
Message-ID: <4817391.g2eX6rsJJ6@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20160211160438.GH28452@windriver.com>
References: <1455205297-1021302-1-git-send-email-arnd@arndb.de> <1455205297-1021302-6-git-send-email-arnd@arndb.de> <20160211160438.GH28452@windriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:rHq6nxooHN6jG6BrvhDYsPMOBR8VeBjx29lBFlbCOj5HurDpvjB
 62kVZM2xD5aE6S2IMeaPZVk2Oz9W/dQ+OsosB3PAg8zYt2Sa6Flq4G5TYhEuspN+KLzsaj3
 DBSL7b25xWwOhXMLkvcLECI5WyjtLAyNDH1KSUQ5/8WE5PGg0Sx79b/kJLxBM/ES48x0iIw
 0huZ0PaiLEieuJapDyI/Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:fP25OcIAW4c=:u3II+s6Qj23WPByRUGA48V
 Un7BGp0B/YdIJKtz4MqoI2omV+n61GvPF4tMwzkFg5o/U/rdcHu8V8auOrX1YGbiAnAIfL2RK
 DQDKFOPaCscKBrvIPYvW6AIqQdIc1MM0BOjVpbWqY03jYMTmtYBpWv7TZm+g9vAsycP+6zh1N
 gTSXyxrtjR6nDple2SoZ9UMpiC+NKB1ZJ97g+oLleaxvMYgAkGqPmrMmh2dtG66CRH9SJ6dno
 Il8wj2gSAw4XVa9TXJ5RJYAW9ZyhVyVezOAVqeDFwsAz5Q8H0t4FbomZTQBc7S1GYfYxXiKHE
 F3XZb4QyhhtmvoqO5SgSp5I7vtjsDNSPxRX19b+4vpCdIzXNqtfeFIuHfmDDMN7xySIUJBcep
 i5hmLMfUan4qRwswOVNhzUlLcJIKU4Y5b2/auS+LJtzHpfSKILMIUzjpgj/ixMin0Bq7SZgjL
 GFhJoOIYyjhWV6qCMkX2gtc9enUGpIX3q5lBoWLZSCQUBqbyPc4O4V1PEyL2+jpe9Udrpczu5
 LeAH9Uy/pmMPBSqEKCMeeIU/lF6ipDlB6FXve1+Bk3Nx5KwUpNPscj0sqRBbECRDMA6tQiGjr
 mKZU7gNGO3isPz0MAN1ZtfjAbBaqkndUSDFHwqQb9kwtJsOhiS6UojiXdSPpVRK/gDgOdXI6I
 CWi8pY8EOskat7CpzJIcCinsk3e2euie80sO2rIb6RasEpUNjvqr/vFzXaNa5GdRiDYGkfP+g
 Yea++TVznX6fj7lS
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 11 February 2016 11:04:38 you wrote:
> > diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> > index 6ecc6e3e82dc..55be90c1d85e 100644
> > --- a/drivers/tty/serial/8250/8250_mtk.c
> > +++ b/drivers/tty/serial/8250/8250_mtk.c
> > @@ -19,6 +19,7 @@
> >  #include <linux/module.h>
> >  #include <linux/of_irq.h>
> >  #include <linux/of_platform.h>
> > +#include <linux/module.h>
> 
> Something isn't right here ; I can see module.h three lines up in the
> context.  Guessing your addition of the revert makes this addition no
> longer required...
> 

Ok, thanks for noticing this. Also, I really should know my alphabet
at this point. I saw that the headers were sorted alphabetically and
thought I had added it in the right place, which would have worked fine
after the revert. Oh well.

	Arnd