public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stas Sergeev <stsp@aknet.ru>
To: Takashi Iwai <tiwai@suse.de>
Cc: Greg KH <gregkh@suse.de>,
	Linux kernel <linux-kernel@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: patch	driver-core-warn-about-duplicate-driver-names-on-the-same-bus.patch added to gregkh-2.6 tree
Date: Tue, 29 Apr 2008 23:28:42 +0400	[thread overview]
Message-ID: <481776EA.5010200@aknet.ru> (raw)
In-Reply-To: <s5habjdvt6z.wl%tiwai@suse.de>

Hello.

Takashi Iwai wrote:
> Though, I think the snd-pcsp driver could be better built on the top
> of input pcspkr driver, or coexist with it.  Then we'll have no more
> conflict about platform name space.
I was trying this in the past.
This never worked out very well.
I disliked the dependancies.
Either snd-pcsp was loading pcspkr,
or there had to be the global variable
to prevent the concurrent access, and
that hurts modularity.

> When you compare input pcspkr.c and sound pcsp_input.c, you can find
> that most of codes are identical.
Yep, its a copy/paste mainly.
I wanted a complete replacement.
Back then, I've been told that multiple
drivers controlling the same device is
never a good idea. But I won't be surprised
if that have changed since. :)

> What we'd need is a hook on
> pcspkr.c that adds a dynamic check whether snd-pcsp (or any ohter)
> is running.
How?
And also, with snd-pcsp you have a
mixer control to disable the beeps,
which I find sometimes even more
usefull than the pcm sound itself. :)

  parent reply	other threads:[~2008-04-29 19:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <12094266793898@kroah.org>
2008-04-29  4:48 ` patch driver-core-warn-about-duplicate-driver-names-on-the-same-bus.patch added to gregkh-2.6 tree Stas Sergeev
2008-04-29  4:58   ` Greg KH
2008-04-29 10:41     ` Takashi Iwai
2008-04-29 15:14       ` Greg KH
2008-04-29 16:41         ` Takashi Iwai
2008-04-29 16:56           ` Greg KH
2008-04-29 19:28       ` Stas Sergeev [this message]
2008-04-30  6:34         ` Takashi Iwai
2008-04-30 17:45           ` Stas Sergeev
2008-05-02 14:07             ` Takashi Iwai
2008-05-02 15:38               ` Stas Sergeev
2008-05-02 16:00                 ` Takashi Iwai
2008-05-02 16:22                   ` Stas Sergeev
2008-05-02 16:35                     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481776EA.5010200@aknet.ru \
    --to=stsp@aknet.ru \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox