Re: [PATCH 0/1] x86: fix remove cpu_pda table patch

[Mike Travis <travis@sgi.com>]

Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
>> * Mike Travis <travis@sgi.com> wrote:
>>
>>> -	prev_nmi_count = kmalloc(NR_CPUS * sizeof(int), GFP_KERNEL);
>>> +	prev_nmi_count = kmalloc(nr_cpu_ids * sizeof(int), GFP_KERNEL);
>> yeah, that makes sense ... i'll reinstate your patches and check.
> 
> they crashed after about 3 randconfig iterations with:
> 
>   early res: 4 [8000-afff] PGTABLE
>   early res: 5 [b000-b87f] MEMNODEMAP
> PANIC: early exception 0e rip 10:ffffffff8077a150 error 2 cr2 37
> Pid: 0, comm: swapper Not tainted 2.6.25-sched-devel.git-x86-latest.git #14
> 
> Call Trace:
>  [<ffffffff81466196>] early_idt_handler+0x56/0x6a
>  [<ffffffff8077a150>] ? numa_set_node+0x30/0x60
>  [<ffffffff8077a129>] ? numa_set_node+0x9/0x60
>  [<ffffffff8147a543>] numa_init_array+0x93/0xf0
>  [<ffffffff8147b039>] acpi_scan_nodes+0x3b9/0x3f0
>  [<ffffffff8147a496>] numa_initmem_init+0x136/0x150
>  [<ffffffff8146da5f>] setup_arch+0x48f/0x700
>  [<ffffffff802566ea>] ? clockevents_register_notifier+0x3a/0x50
>  [<ffffffff81466a87>] start_kernel+0xd7/0x440
>  [<ffffffff81466422>] x86_64_start_kernel+0x222/0x280
> 
> RIP 0x10
> 
> 
>  http://redhat.com/~mingo/misc/log-Wed_Apr_30_00_28_09_CEST_2008.bad
>  http://redhat.com/~mingo/misc/config-Wed_Apr_30_00_28_09_CEST_2008.bad
> 
> 	Ingo

Thanks, I'll check it out asap.

I might have to change the approach of the "remove pdas" patch a bit to
make it more "fail safe".

Thanks,
Mike