Re: [PATCH] m68knommu: Add info about removing mcfserial

[Greg Ungerer <gerg@snapgear.com>]

Sebastian Siewior wrote:
> From: Sebastian Siewior <bigeasy@linutronix.de>
> 
> Schedule a removal for this driver. Alternative driver is
> available for a while now.
> 
> Signed-off-by: Sebastian Siewior <bigeasy@linutronix.de>
> ---
> Greg said [1] and I hope .28 is not too late.
> [1] http://www.mail-archive.com/uclinux-dev@uclinux.org/msg04453.html

.28 is ok with me.

Regards
Greg



>  Documentation/feature-removal-schedule.txt |    8 ++++++++
>  drivers/serial/Kconfig                     |    6 +++++-
>  drivers/serial/mcfserial.c                 |    1 +
>  3 files changed, 14 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> index 3c35d45..27c0056 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -304,3 +304,11 @@ When:	2.6.26
>  Why:	Implementation became generic; users should now include
>  	linux/semaphore.h instead.
>  Who:	Matthew Wilcox <willy@linux.intel.com>
> +
> +---------------------------
> +
> +What:	old style serial driver for ColdFire (CONFIG_SERIAL_COLDFIRE)
> +When:	2.6.28
> +Why:	This driver still uses the old interface and has been replaced
> +	by CONFIG_SERIAL_MCF.
> +Who:	Sebastian Siewior <sebastian@breakpoint.cc>
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index 36acbcc..62e6eb1 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -976,11 +976,15 @@ config SERIAL_68328_RTS_CTS
>  	depends on SERIAL_68328
>  
>  config SERIAL_COLDFIRE
> -	bool "ColdFire serial support"
> +	bool "ColdFire serial support (DEPRECATED)"
>  	depends on COLDFIRE
>  	help
>  	  This driver supports the built-in serial ports of the Motorola ColdFire
>  	  family of CPUs.
> +	  This driver is deprecated because it supports only the old interface
> +	  for serial drivers and features like magic keys are not working.
> +	  Please switch to the new style driver because this driver will be
> +	  removed soon.
>  
>  config SERIAL_MCF
>  	bool "Coldfire serial support (new style driver)"
> diff --git a/drivers/serial/mcfserial.c b/drivers/serial/mcfserial.c
> index 43af40d..56007cc 100644
> --- a/drivers/serial/mcfserial.c
> +++ b/drivers/serial/mcfserial.c
> @@ -1,3 +1,4 @@
> +#warning This driver is deprecated. Check Kconfig for details.
>  /*
>   * mcfserial.c -- serial driver for ColdFire internal UARTS.
>   *

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg@snapgear.com
Secure Computing Corporation                PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com