From: Joel Schopp <jschopp@austin.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: questions on calc_delta_mine() in sched.c
Date: Thu, 01 May 2008 15:45:42 -0500 [thread overview]
Message-ID: <481A2BF6.2070406@austin.ibm.com> (raw)
Ingo,
I have a few questions regarding this code in kernel/sched.c
static unsigned long
calc_delta_mine(unsigned long delta_exec, unsigned long weight,
struct load_weight *lw)
{
u64 tmp;
if (unlikely(!lw->inv_weight))
lw->inv_weight = (WMULT_CONST-lw->weight/2) / (lw->weight+1);
Q1) This code is hit often in scenarios I run, is this really unlikely for
others?
Q2) The rest of the code in sched.c seems to make inv_weight ==
WMULT_CONST/weight and I was wondering if you could explain why this
instance is different.
Q3) That division is pretty expensive, could we sacrifice some accuracy and
do a precompute table? Do you have another idea how we could get rid of
the divide?
-Joel Schopp
next reply other threads:[~2008-05-01 20:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 20:45 Joel Schopp [this message]
2008-05-02 12:14 ` questions on calc_delta_mine() in sched.c Peter Zijlstra
2008-05-02 12:30 ` Peter Zijlstra
2008-05-02 13:10 ` Peter Zijlstra
2008-05-02 18:46 ` Joel Schopp
2008-05-02 18:55 ` Peter Zijlstra
2008-05-02 20:30 ` Joel Schopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481A2BF6.2070406@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox