From: Jiri Slaby <jirislaby@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
sandeen@sandeen.net
Subject: Re: [PATCH] i386: Execute stack overflow warning on interrupt stack
Date: Fri, 02 May 2008 11:45:05 +0200 [thread overview]
Message-ID: <481AE2A1.7000201@gmail.com> (raw)
In-Reply-To: <20080502091806.GA26062@basil.nowhere.org>
On 05/02/2008 11:18 AM, Andi Kleen wrote:
> i386: Execute stack overflow warning on interrupt stack
[...]
> --- linux.orig/arch/x86/kernel/irq_32.c
> +++ linux/arch/x86/kernel/irq_32.c
> @@ -61,6 +61,26 @@ static union irq_ctx *hardirq_ctx[NR_CPU
> static union irq_ctx *softirq_ctx[NR_CPUS] __read_mostly;
> #endif
>
> +static void stack_overflow(void)
> +{
> + printk("low stack detected by irq handler\n");
> + dump_stack();
> +}
> +
> +static inline void call_on_stack2(void *func, unsigned long stack,
> + unsigned long arg1, unsigned long arg2)
> +{
> + unsigned long bx;
> + asm volatile(
> + " xchgl %%ebx,%%esp \n"
> + " call *%%edi \n"
> + " movl %%ebx,%%esp \n"
> + : "=a" (arg1), "=d" (arg2), "=b" (bx)
> + : "0" (arg1), "1" (arg2), "2" (stack),
> + "D" (func)
> + : "memory", "cc", "ecx');
Am I seeing wrong, or is it a ' after the ecx?
next prev parent reply other threads:[~2008-05-02 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 9:18 [PATCH] i386: Execute stack overflow warning on interrupt stack Andi Kleen
2008-05-02 9:45 ` Jiri Slaby [this message]
2008-05-02 9:48 ` Andi Kleen
2008-05-02 9:45 ` [PATCH] i386: Execute stack overflow warning on interrupt stack II Andi Kleen
2008-05-05 9:59 ` Thomas Gleixner
2008-05-05 10:17 ` Andi Kleen
2008-05-05 12:39 ` Thomas Gleixner
2008-05-05 13:13 ` Eric Sandeen
2008-05-05 13:29 ` Andi Kleen
2008-05-05 13:42 ` Pekka Enberg
2008-05-05 13:45 ` Andi Kleen
2008-05-05 13:42 ` [PATCH] i386: Execute stack overflow warning on interrupt stack Eric Sandeen
2008-05-05 13:47 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481AE2A1.7000201@gmail.com \
--to=jirislaby@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sandeen@sandeen.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox