public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Alistair John Strachan <alistair@devzero.co.uk>,
	Chris Knadle <Chris.Knadle@coredump.us>,
	Andrew Morton <akpm@linux-foundation.org>,
	Adrian Bunk <bunk@kernel.org>,
	venkatesh.pallipadi@intel.com, davem@davemloft.net,
	trini@kernel.crashing.org, mingo@elte.hu, tglx@linutronix.de,
	hpa@zytor.com, linux-kernel@vger.kernel.org,
	suresh.b.siddha@intel.com,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: huge gcc 4.1.{0,1} __weak problem
Date: Fri, 02 May 2008 07:57:42 -0700	[thread overview]
Message-ID: <481B2BE6.3050708@goop.org> (raw)
In-Reply-To: <20080502135708.GA22929@uranus.ravnborg.org>

Sam Ravnborg wrote:
> OK, can anyone confirm that this fails to build which a
> buggy gcc:
>
>
> void __attribute__((weak)) func(void)
> {
>     /* no code */
> }
>
> int main()
> {
>     func();
>     return 0;
> }
>   

I think the problem is that main() would have no call to func(), not 
that it wouldn't build.

Does making func noinline fix it?  I wonder if we should make __weak 
implicitly make the function noinline too.

    J

  parent reply	other threads:[~2008-05-02 14:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 23:55 huge gcc 4.1.{0,1} __weak problem Chris Knadle
2008-05-02  9:19 ` Miquel van Smoorenburg
2008-05-02  9:55 ` Alistair John Strachan
2008-05-02 10:43   ` Sam Ravnborg
2008-05-02 11:48     ` Alistair John Strachan
2008-05-02 13:57       ` Sam Ravnborg
2008-05-02 14:11         ` Jakub Jelinek
2008-05-02 15:26           ` Alistair John Strachan
2008-05-02 14:57         ` Jeremy Fitzhardinge [this message]
2008-05-02 12:40   ` Sven-Haegar Koch
  -- strict thread matches above, loose matches on Subject: below --
2008-04-30  1:31 [PATCH] /dev/mem gcc weak function workaround Venki Pallipadi
2008-04-30  4:28 ` David Miller
2008-04-30 12:49   ` Pallipadi, Venkatesh
2008-05-01 21:56     ` huge gcc 4.1.{0,1} __weak problem Adrian Bunk
2008-05-01 22:20       ` Andrew Morton
2008-05-01 22:27         ` Linus Torvalds
2008-05-01 22:33           ` Andrew Morton
2008-05-01 23:24             ` Tom Rini
2008-05-01 23:59               ` Andrew Morton
2008-05-02  0:21                 ` Justin Mattock
2008-05-02  7:18                 ` Vegard Nossum
2008-05-02 13:43                   ` Theodore Tso
2008-05-02  8:10                 ` Adrian Bunk
2008-05-02  9:09                 ` Andi Kleen
2008-05-01 22:35           ` Venki Pallipadi
2008-05-01 22:42             ` Andrew Morton
2008-05-01 22:49               ` Jakub Jelinek
2008-05-01 23:21               ` Tom Rini
2008-05-01 23:30                 ` Venki Pallipadi
2008-05-02  0:34                   ` Linus Torvalds
2008-05-02  0:39                     ` Suresh Siddha
2008-05-02 21:11                       ` Jeremy Fitzhardinge
2008-05-02 22:02                         ` David Miller
2008-05-01 23:23             ` Tom Rini
2008-05-01 22:51           ` David Miller
2008-05-02 21:09       ` Jeremy Fitzhardinge
2008-05-02 21:19         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481B2BE6.3050708@goop.org \
    --to=jeremy@goop.org \
    --cc=Chris.Knadle@coredump.us \
    --cc=akpm@linux-foundation.org \
    --cc=alistair@devzero.co.uk \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=trini@kernel.crashing.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox