From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935361AbYEBQWr (ORCPT ); Fri, 2 May 2008 12:22:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759310AbYEBQWj (ORCPT ); Fri, 2 May 2008 12:22:39 -0400 Received: from mail.AKNET.ru ([77.246.241.226]:54170 "EHLO mail.aknet.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757788AbYEBQWi (ORCPT ); Fri, 2 May 2008 12:22:38 -0400 Message-ID: <481B3FBF.9070004@aknet.ru> Date: Fri, 02 May 2008 20:22:23 +0400 From: Stas Sergeev User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Takashi Iwai CC: Linux kernel , Dmitry Torokhov Subject: Re: patch driver-core-warn-about-duplicate-driver-names-on-the-same-bus.patch added to gregkh-2.6 tree References: <12094266793898@kroah.org> <4816A888.9000802@aknet.ru> <20080429045849.GA6348@suse.de> <481776EA.5010200@aknet.ru> <4818B057.4080803@aknet.ru> <481B355B.9040200@aknet.ru> In-Reply-To: X-Enigmail-Version: 0.95.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. Takashi Iwai wrote: >> Another point is PM callbacks. Somehow >> snd-pcsp will have to register them with >> pcspkr. > Hmm, isn't platform PM hook enough? > pcspkr.c just sends an event at suspend or shutdown to the event > handler. So, if the event was shut up at the beginning in the > handler, nothing would be needed. I don't think I understand what you mean... Currently, pcspkr.c just stops the timer counter to shut up the beep. snd-pcsp needs more. snd_pcm_suspend_all() for instance. Since it doesn't register itself as a platform driver any more, he have to register itself into pcspkr.c. Or? I mean, sending a "shut up" event to the pcspkr's handler is not what snd-pcsp needs to do.