Re: Slow DOWN, please!!!

Adrian Bunk
2008-05-01T02:14:27Z

On Wed, Apr 30, 2008 at 06:25:50PM -0700, Linus Torvalds wrote:
>
>
> On Thu, 1 May 2008, Adrian Bunk wrote:
> >
> > One big problem I see is Linus wanting to merge all drivers regardless
> > of the quality.
>
> That's not what I said.
>
> What I said was that I think we get *better* quality by merging early.
>
> In other words, you're turning the whole argument on its head, and
> incorrectly so.
>
> I claim that you are the one that is arguing for *worse* quality, by
> arguing for a process that is KNOWN to tend to generate bad code
> (out-of-tree drivers) as opposed to one that tends to fix things over time
> (and note the "tends" in both cases - there are counter-examples, but
> the trend is so clear that anybody who disputes it would seem to be either
> blind or lying).
>...

I am *not* saying it should have stayed out-of-tree.

I am saying that it was merged too early, and that there are points that
should have been addressed before the driver got merged.

Get it submitted for review to linux-kernel.
Give the maintainers some time to incorporate all comments.
Even one month later it could still have made it into 2.6.25.

The only problem with my suggestion is that it's currently pretty random
whether someone takes the time to review such a driver on linux-kernel.

And even if I'm getting fire for this again (and different from newbies
running checkpatch on the kernel) for driver submissions it actually
makes sense to tell the submitter to fix the checkpatch errors [1], and
it would have made the driver better in this case (again, it could still
have made it into 2.6.25).

People are actually more motivated to fix their code for getting it into
the kernel than to fix their code after it went into the kernel, so we
might get better quality when merging a bit later.

> Linus

cu
Adrian

[1] not necessarily all checkpatch warnings

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed