* [PATCH] x86: fix up bootparam.h for userspace inclusion
@ 2008-05-02 11:14 Rusty Russell
2008-05-02 18:51 ` H. Peter Anvin
2008-05-03 21:04 ` Thomas Gleixner
0 siblings, 2 replies; 3+ messages in thread
From: Rusty Russell @ 2008-05-02 11:14 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Huang Ying
commit 8b664aa66e824a0ddf4ec56d41fa0cf7bb374de6 (x86, boot: add linked
list of struct setup_data) put a new struct in bootparam.h, but didn't
use the userspace-safe types.
CC: Huang, Ying <ying.huang@intel.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r 3b015cd747e0 include/asm-x86/bootparam.h
--- a/include/asm-x86/bootparam.h Fri May 02 09:32:30 2008 +1000
+++ b/include/asm-x86/bootparam.h Fri May 02 18:35:11 2008 +1000
@@ -14,10 +14,10 @@
/* extensible setup data list node */
struct setup_data {
- u64 next;
- u32 type;
- u32 len;
- u8 data[0];
+ __u64 next;
+ __u32 type;
+ __u32 len;
+ __u8 data[0];
};
struct setup_header {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: fix up bootparam.h for userspace inclusion
2008-05-02 11:14 [PATCH] x86: fix up bootparam.h for userspace inclusion Rusty Russell
@ 2008-05-02 18:51 ` H. Peter Anvin
2008-05-03 21:04 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2008-05-02 18:51 UTC (permalink / raw)
To: Rusty Russell; +Cc: Ingo Molnar, linux-kernel, Huang Ying
Rusty Russell wrote:
> commit 8b664aa66e824a0ddf4ec56d41fa0cf7bb374de6 (x86, boot: add linked
> list of struct setup_data) put a new struct in bootparam.h, but didn't
> use the userspace-safe types.
>
> CC: Huang, Ying <ying.huang@intel.com>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: H. Peter Anvin <hpa@zytor.com>
-hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: fix up bootparam.h for userspace inclusion
2008-05-02 11:14 [PATCH] x86: fix up bootparam.h for userspace inclusion Rusty Russell
2008-05-02 18:51 ` H. Peter Anvin
@ 2008-05-03 21:04 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2008-05-03 21:04 UTC (permalink / raw)
To: Rusty Russell; +Cc: Ingo Molnar, linux-kernel, Huang Ying
On Fri, 2 May 2008, Rusty Russell wrote:
> commit 8b664aa66e824a0ddf4ec56d41fa0cf7bb374de6 (x86, boot: add linked
> list of struct setup_data) put a new struct in bootparam.h, but didn't
> use the userspace-safe types.
>
> CC: Huang, Ying <ying.huang@intel.com>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> diff -r 3b015cd747e0 include/asm-x86/bootparam.h
> --- a/include/asm-x86/bootparam.h Fri May 02 09:32:30 2008 +1000
> +++ b/include/asm-x86/bootparam.h Fri May 02 18:35:11 2008 +1000
> @@ -14,10 +14,10 @@
>
> /* extensible setup data list node */
> struct setup_data {
> - u64 next;
> - u32 type;
> - u32 len;
> - u8 data[0];
> + __u64 next;
> + __u32 type;
> + __u32 len;
> + __u8 data[0];
> };
>
> struct setup_header {
Applied, thanks
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-03 21:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-02 11:14 [PATCH] x86: fix up bootparam.h for userspace inclusion Rusty Russell
2008-05-02 18:51 ` H. Peter Anvin
2008-05-03 21:04 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox