From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Carlos R. Mafra" <crmafra@ift.unesp.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/time.c: Silence gcc warning 'integer constant to large for long type'
Date: Fri, 02 May 2008 15:45:55 -0700 [thread overview]
Message-ID: <481B99A3.3080603@zytor.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0805021528080.5994@woody.linux-foundation.org>
Linus Torvalds wrote:
>
> Make the timeconst.h file just contain sane macros. No preprocessor games
> etc. Just make it say
>
> #define USEC_TO_HZ_MUL32 ..correct-value-here..
>
> and not even generate macros with values that cannot be used (ie >64
> bits).
>
OK. I was being too general, I guess (holding out for stuff like doing
this in 64-bit space which would require 128-bit constants, which gcc
*does* support on 64-bit platforms.)
I'll have a clean patch shortly.
-hpa
next prev parent reply other threads:[~2008-05-02 22:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:58 [PATCH] kernel/time.c: Silence gcc warning 'integer constant to large for long type' H. Peter Anvin
2008-05-02 21:14 ` Linus Torvalds
2008-05-02 21:33 ` H. Peter Anvin
2008-05-02 22:17 ` Linus Torvalds
2008-05-02 22:33 ` Linus Torvalds
2008-05-02 22:45 ` H. Peter Anvin [this message]
2008-05-02 23:23 ` H. Peter Anvin
2008-05-03 17:57 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481B99A3.3080603@zytor.com \
--to=hpa@zytor.com \
--cc=crmafra@ift.unesp.br \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox