From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965112AbYECAJR (ORCPT ); Fri, 2 May 2008 20:09:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964955AbYECAIj (ORCPT ); Fri, 2 May 2008 20:08:39 -0400 Received: from terminus.zytor.com ([198.137.202.10]:33489 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935633AbYECAIi (ORCPT ); Fri, 2 May 2008 20:08:38 -0400 Message-ID: <481BACEC.8080902@zytor.com> Date: Fri, 02 May 2008 17:08:12 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Hiroshi Shimamoto CC: Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: x86 git acpi issue? References: <481BAC6F.5090509@ct.jp.nec.com> In-Reply-To: <481BAC6F.5090509@ct.jp.nec.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hiroshi Shimamoto wrote: > Hi, > > commit: afcab879e4044f952b7a031d5fd504e0feb7df41 > visws: build fix > > breaks something around acpi on 32bit. > In my test box scsi driver complains and the kernel doesn't boot. > > I'm not sure, but when moving the acpi.o before legacy.o, it works. > --- a/arch/x86/pci/Makefile_32 > +++ b/arch/x86/pci/Makefile_32 > @@ -6,11 +6,11 @@ obj-$(CONFIG_PCI_DIRECT) += direct.o > obj-$(CONFIG_PCI_OLPC) += olpc.o > > pci-y := fixup.o > +pci-$(CONFIG_ACPI) += acpi.o > pci-y += legacy.o irq.o > > pci-$(CONFIG_X86_VISWS) := visws.o fixup.o > pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o > -pci-$(CONFIG_ACPI) += acpi.o > pci-$(CONFIG_NUMA) += mp_bus_to_node.o > > obj-y += $(pci-y) common.o early.o > > of cause this isn't correct patch, it's just a workaround for me. > The problem is that := should be += for the VISWS and NUMAQ lines. There is already a patch queued up to fix that. -hpa