From: Eric Sandeen <sandeen@redhat.com>
To: "Jörn Engel" <joern@logfs.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jörn Engel" <joern@lazybastard.org>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] find dynamic stack allocations in checkstack.pl
Date: Fri, 02 May 2008 21:21:40 -0500 [thread overview]
Message-ID: <481BCC34.80808@redhat.com> (raw)
In-Reply-To: <20080502223539.GH24080@logfs.org>
Jörn Engel wrote:
> On Fri, 2 May 2008 12:26:29 -0500, Eric Sandeen wrote:
>> @@ -142,6 +148,22 @@ while (my $line = <STDIN>) {
>> next if ($size < 100);
>> push @stack, "$intro$size\n";
>> }
>> + elsif (defined $dre && $line =~ m/$dre/) {
>
> These two could join a line. Otherwise an excellent addition.
Thanks... was just following the existing style (in this part of the
file, anyway...)
-Eric
> Reviewed-By: Joern Engel <joern@logfs.org>
>
> Jörn
>
prev parent reply other threads:[~2008-05-03 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 17:26 [PATCH] find dynamic stack allocations in checkstack.pl Eric Sandeen
2008-05-02 22:35 ` Jörn Engel
2008-05-03 2:21 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481BCC34.80808@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=joern@lazybastard.org \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox