From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-next@vger.kernel.org, sfrench@us.ibm.com,
swhiteho@redhat.com, ralf@linux-mips.org, drzeus-list@drzeus.cx,
jack@ucw.cz, cbou@mail.ru, jens.axboe@oracle.com,
ericvh@gmail.com, wim@iguana.be, chris@zankel.net, nico@cam.org,
penberg@cs.helsinki.fi, clameter@sgi.com, ezk@cs.sunysb.edu,
linux-kernel@vger.kernel.org
Subject: Re: git trees which are not yet in linux-next
Date: Sat, 03 May 2008 00:52:10 -0400 [thread overview]
Message-ID: <481BEF7A.1060300@garzik.org> (raw)
In-Reply-To: <20080502183403.3d9f2d9f.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Sat, 03 May 2008 03:19:00 +0200 Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>
>> Andrew Morton wrote:
>>> On Fri, 2 May 2008 15:12:06 -0700
>>> Andrew Morton <akpm@linux-foundation.org> wrote:
>>>
>>>> The first
>>>> problem is working out "how the heck did that patch get into linux-next"?
>>>> That would be much easier if the signoff trail was complete for git-based
>>>> patches, but it often is not.
>>> doh. I'm pulling linux-next's constituent trees independently, so if I
>>> spot a turd in linux-next I can just grep the various git trees to find out
>>> where it came from.
>>>
>>> It seems wrong though...
>> What about the committer info? Well, I suppose a nobody@localhost slips
>> in, but more often I expect it to be something more telling than that.
>
> Beats me. To pick one example:
>
> commit 1a72963d3af38eb17a939fc19b322735da1c0aad
> Author: Matthew Wilcox <matthew@wil.cx>
> Date: Fri Apr 25 12:38:41 2008 -0400
>
> Convert board-nokia770 from semaphore to spinlock
>
> None of the operations done under the semaphore could sleep, so a spinlock
> is more appropriate to this case.
>
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
>
> There's no sign how that got there. A bit of forensics shows up:
Poke through the man pages, particularly git-log, and tell it to spit
out the committer info, then. It's in there.
For example,
git log --pretty=full
produces
commit c4d0f8cbca3a97900f85b082064a63c7a5928bd7
Author: Alan Cox <alan@lxorguk.ukuu.org.uk>
Commit: Greg Kroah-Hartman <gregkh@suse.de>
usb_serial: some coding style fixes
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Regards,
Jeff
next prev parent reply other threads:[~2008-05-03 4:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 22:12 git trees which are not yet in linux-next Andrew Morton
2008-05-02 22:20 ` Jeff Garzik
2008-05-02 22:33 ` Andrew Morton
2008-05-03 4:33 ` Stephen Rothwell
2008-05-03 4:54 ` Jeff Garzik
2008-05-02 22:42 ` Andrew Morton
2008-05-03 1:19 ` Stefan Richter
2008-05-03 1:34 ` Andrew Morton
2008-05-03 4:52 ` Jeff Garzik [this message]
2008-05-03 8:46 ` Stefan Richter
2008-05-05 0:18 ` Stephen Rothwell
2008-05-03 1:11 ` Stefan Richter
2008-05-03 1:18 ` Andrew Morton
2008-05-05 16:52 ` Liam Girdwood
2008-05-05 17:57 ` Andrew Morton
2008-05-06 4:45 ` Stephen Rothwell
2008-05-06 5:50 ` Andrew Morton
2008-05-06 7:18 ` Stephen Rothwell
2008-05-05 18:16 ` Pekka Enberg
2008-05-05 18:31 ` Andrew Morton
2008-05-05 18:41 ` Pekka J Enberg
2008-05-05 19:40 ` Stefan Richter
2008-05-05 21:11 ` Daniel Hazelton
2008-05-06 4:41 ` Stephen Rothwell
2008-05-06 4:43 ` Stephen Rothwell
2008-05-13 6:36 ` Pierre Ossman
2008-05-13 7:00 ` Stephen Rothwell
2008-05-13 10:47 ` Pierre Ossman
2008-05-13 12:33 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481BEF7A.1060300@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=cbou@mail.ru \
--cc=chris@zankel.net \
--cc=clameter@sgi.com \
--cc=drzeus-list@drzeus.cx \
--cc=ericvh@gmail.com \
--cc=ezk@cs.sunysb.edu \
--cc=jack@ucw.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nico@cam.org \
--cc=penberg@cs.helsinki.fi \
--cc=ralf@linux-mips.org \
--cc=sfrench@us.ibm.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=swhiteho@redhat.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox