* [patch][resend] pcspkr: fix dependancies
@ 2008-05-03 11:51 Stas Sergeev
2008-05-03 20:01 ` Thomas Gleixner
0 siblings, 1 reply; 6+ messages in thread
From: Stas Sergeev @ 2008-05-03 11:51 UTC (permalink / raw)
To: Ingo Molnar
Cc: Takashi Iwai, Linux kernel, Dmitry Torokhov, Vojtech Pavlik,
Michael Opdenacker
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
Hello.
linux-2.6.25 has the strange dependancies
for pc-speaker, which prevents snd-pcsp
from working.
Namely, the platform device (created in
arch/x86/kernel/pcspeaker.c) depends on
the platform driver (CONFIG_INPUT_PCSPKR).
I wonder if it is a good practice to make
the platform device to depend on the driver,
I guess it is not.
The attached patch reverses that.
It adds the config option for the pcspkr
platform device and makes the platform
drivers to depend on that.
This allows snd-pcsp to work at least in
some configurations.
Ingo, would it be possible to get that
applied?
---
fix pcspkr dependancies: make the pcspkr platform
drivers to depend on a platform device, and
not the other way around.
Signed-off-by: Stas Sergeev <stsp@aknet.ru>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Vojtech Pavlik <vojtech@suse.cz>
CC: Michael Opdenacker <michael-lists@free-electrons.com>
CC: Takashi Iwai <tiwai@suse.de>
[-- Attachment #2: pcsp_dep2.diff --]
[-- Type: text/x-patch, Size: 1314 bytes --]
--- a/init/Kconfig 2008-04-26 13:40:20.000000000 +0400
+++ b/init/Kconfig 2008-04-26 18:20:40.000000000 +0400
@@ -624,6 +624,14 @@
help
Enable support for generating core dumps. Disabling saves about 4k.
+config PCSPKR_PLATFORM
+ bool "Enable PC-Speaker support" if EMBEDDED
+ depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
+ default y
+ help
+ This option allows to disable the internal PC-Speaker
+ support, saving some memory.
+
config COMPAT_BRK
bool "Disable heap randomization"
default y
--- a/arch/x86/kernel/Makefile 2008-04-26 13:40:06.000000000 +0400
+++ b/arch/x86/kernel/Makefile 2008-04-26 18:22:49.000000000 +0400
@@ -83,7 +83,7 @@
obj-$(CONFIG_VMI) += vmi_32.o vmiclock_32.o
obj-$(CONFIG_PARAVIRT) += paravirt.o paravirt_patch_$(BITS).o
-ifdef CONFIG_INPUT_PCSPKR
+ifdef CONFIG_PCSPKR_PLATFORM
obj-y += pcspeaker.o
endif
--- a/drivers/input/misc/Kconfig 2008-04-22 20:50:41.000000000 +0400
+++ b/drivers/input/misc/Kconfig 2008-04-26 18:23:32.000000000 +0400
@@ -14,7 +14,7 @@
config INPUT_PCSPKR
tristate "PC Speaker support"
- depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
+ depends on PCSPKR_PLATFORM
help
Say Y here if you want the standard PC Speaker to be used for
bells and whistles.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch][resend] pcspkr: fix dependancies
2008-05-03 11:51 [patch][resend] pcspkr: fix dependancies Stas Sergeev
@ 2008-05-03 20:01 ` Thomas Gleixner
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2008-05-03 20:01 UTC (permalink / raw)
To: Stas Sergeev
Cc: Ingo Molnar, Takashi Iwai, Linux kernel, Dmitry Torokhov,
Vojtech Pavlik, Michael Opdenacker
On Sat, 3 May 2008, Stas Sergeev wrote:
>
> Ingo, would it be possible to get that
> applied?
The input changes need to go via Dimitry, the x86 part can go in the
same commit.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> fix pcspkr dependancies: make the pcspkr platform
> drivers to depend on a platform device, and
> not the other way around.
>
> Signed-off-by: Stas Sergeev <stsp@aknet.ru>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> CC: Vojtech Pavlik <vojtech@suse.cz>
> CC: Michael Opdenacker <michael-lists@free-electrons.com>
> CC: Takashi Iwai <tiwai@suse.de>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch][resend] pcspkr: fix dependancies
@ 2008-05-04 4:22 Stas Sergeev
2008-05-05 3:57 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Stas Sergeev @ 2008-05-04 4:22 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Takashi Iwai, Linux kernel, Vojtech Pavlik, Michael Opdenacker,
Thomas Gleixner
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
Thomas Gleixner wrote:
> The input changes need to go via Dimitry, the x86 part can go in the
> same commit.
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
Dmitry, would you mind applying this one?
If not, then I see no way to get either
fix applied...
---
fix pcspkr dependancies: make the pcspkr platform
drivers to depend on a platform device, and
not the other way around.
Signed-off-by: Stas Sergeev <stsp@aknet.ru>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
CC: Vojtech Pavlik <vojtech@suse.cz>
CC: Michael Opdenacker <michael-lists@free-electrons.com>
CC: Takashi Iwai <tiwai@suse.de>
[-- Attachment #2: pcsp_dep2.diff --]
[-- Type: text/x-patch, Size: 1315 bytes --]
--- a/init/Kconfig 2008-04-26 13:40:20.000000000 +0400
+++ b/init/Kconfig 2008-04-26 18:20:40.000000000 +0400
@@ -624,6 +624,14 @@
help
Enable support for generating core dumps. Disabling saves about 4k.
+config PCSPKR_PLATFORM
+ bool "Enable PC-Speaker support" if EMBEDDED
+ depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
+ default y
+ help
+ This option allows to disable the internal PC-Speaker
+ support, saving some memory.
+
config COMPAT_BRK
bool "Disable heap randomization"
default y
--- a/arch/x86/kernel/Makefile 2008-04-26 13:40:06.000000000 +0400
+++ b/arch/x86/kernel/Makefile 2008-04-26 18:22:49.000000000 +0400
@@ -83,7 +83,7 @@
obj-$(CONFIG_VMI) += vmi_32.o vmiclock_32.o
obj-$(CONFIG_PARAVIRT) += paravirt.o paravirt_patch_$(BITS).o
-ifdef CONFIG_INPUT_PCSPKR
+ifdef CONFIG_PCSPKR_PLATFORM
obj-y += pcspeaker.o
endif
--- a/drivers/input/misc/Kconfig 2008-04-22 20:50:41.000000000 +0400
+++ b/drivers/input/misc/Kconfig 2008-04-26 18:23:32.000000000 +0400
@@ -14,7 +14,7 @@
config INPUT_PCSPKR
tristate "PC Speaker support"
- depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
+ depends on PCSPKR_PLATFORM
help
Say Y here if you want the standard PC Speaker to be used for
bells and whistles.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch][resend] pcspkr: fix dependancies
2008-05-04 4:22 Stas Sergeev
@ 2008-05-05 3:57 ` Dmitry Torokhov
2008-05-05 4:26 ` Stas Sergeev
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2008-05-05 3:57 UTC (permalink / raw)
To: Stas Sergeev
Cc: Takashi Iwai, Linux kernel, Vojtech Pavlik, Michael Opdenacker,
Thomas Gleixner
On Sun, May 04, 2008 at 08:22:32AM +0400, Stas Sergeev wrote:
> Thomas Gleixner wrote:
> > The input changes need to go via Dimitry, the x86 part can go in the
> > same commit.
> > Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Dmitry, would you mind applying this one?
> If not, then I see no way to get either
> fix applied...
>
Ok, but don't you need to also add the same dependancy for SND_PCSP?
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch][resend] pcspkr: fix dependancies
2008-05-05 3:57 ` Dmitry Torokhov
@ 2008-05-05 4:26 ` Stas Sergeev
2008-05-05 4:35 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Stas Sergeev @ 2008-05-05 4:26 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Takashi Iwai, Linux kernel, Vojtech Pavlik, Michael Opdenacker,
Thomas Gleixner
Hello.
Dmitry Torokhov wrote:
>> Dmitry, would you mind applying this one?
>> If not, then I see no way to get either
>> fix applied...
> Ok, but don't you need to also add the same dependancy for SND_PCSP?
Thanks!
As for SND_PCSP - I decided to skip
that part and send it as a separate
patch to Takashi, when this one is
settled. Otherwise it would be even
more difficult to find the right person
to apply the whole thing. :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch][resend] pcspkr: fix dependancies
2008-05-05 4:26 ` Stas Sergeev
@ 2008-05-05 4:35 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2008-05-05 4:35 UTC (permalink / raw)
To: Stas Sergeev
Cc: Takashi Iwai, Linux kernel, Vojtech Pavlik, Michael Opdenacker,
Thomas Gleixner
On Mon, May 05, 2008 at 08:26:12AM +0400, Stas Sergeev wrote:
> Hello.
>
> Dmitry Torokhov wrote:
> >> Dmitry, would you mind applying this one?
> >> If not, then I see no way to get either
> >> fix applied...
> > Ok, but don't you need to also add the same dependancy for SND_PCSP?
> Thanks!
> As for SND_PCSP - I decided to skip
> that part and send it as a separate
> patch to Takashi, when this one is
> settled. Otherwise it would be even
> more difficult to find the right person
> to apply the whole thing. :)
Why don't we ask Takashi to apply it in one step? You can add my
Acked-by: Dmitry Torokhov <dtor@mail.ru>
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-05-05 4:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-03 11:51 [patch][resend] pcspkr: fix dependancies Stas Sergeev
2008-05-03 20:01 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2008-05-04 4:22 Stas Sergeev
2008-05-05 3:57 ` Dmitry Torokhov
2008-05-05 4:26 ` Stas Sergeev
2008-05-05 4:35 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox