From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755867AbYEDIzi (ORCPT ); Sun, 4 May 2008 04:55:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752089AbYEDIz2 (ORCPT ); Sun, 4 May 2008 04:55:28 -0400 Received: from smtp1.wifiinternet.cz ([89.31.47.1]:61722 "EHLO bor.wifiinternet.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753109AbYEDIz1 (ORCPT ); Sun, 4 May 2008 04:55:27 -0400 X-Greylist: delayed 1656 seconds by postgrey-1.27 at vger.kernel.org; Sun, 04 May 2008 04:55:27 EDT Message-ID: <481D73B0.8020705@monstr.eu> Date: Sun, 04 May 2008 10:28:32 +0200 From: Michal Simek Reply-To: monstr@seznam.cz User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Arnd Bergmann CC: monstr@seznam.cz, paulus@samba.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 1/1] DEBUGFS: Fixing name for debug fs References: <1209825314-8048-1-git-send-email-monstr@seznam.cz> <200805032307.04352.arnd@arndb.de> In-Reply-To: <200805032307.04352.arnd@arndb.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, This is question up to PowerPC guys not to me. of_debugfs_root sounds good. M >> This change is made because powerpc_debugfs_root is arch >> specific name. > ... >> >> static int powerpc_debugfs_init(void) >> { >> - powerpc_debugfs_root = debugfs_create_dir("powerpc", NULL); >> + debugfs_root = debugfs_create_dir("powerpc", NULL); >> > > You left the name as "powerpc", which sort of defeats the purpose of your > patch. Files in debugfs are by definition not part of the ABI, so it's > actually possible to change this as well. How about making this "of" > instead of "powerpc"? > > Arnd <>< >