public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] remove duplicate definition of sysfs_update_group()
@ 2008-05-04 14:17 Dmitri Vorobiev
  2008-05-04 22:08 ` Dmitri Vorobiev
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitri Vorobiev @ 2008-05-04 14:17 UTC (permalink / raw)
  To: gregkh, linux-kernel

The stub version of the sysfs_update_group() function is erroneously
provided twice. This patch removes the redundant definition.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
 include/linux/sysfs.h |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 27bad59..7858eac 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -196,12 +196,6 @@ static inline int sysfs_update_group(struct kobject *kobj,
 	return 0;
 }
 
-static inline int sysfs_update_group(struct kobject *kobj,
-				const struct attribute_group *grp)
-{
-	return 0;
-}
-
 static inline void sysfs_remove_group(struct kobject *kobj,
 				      const struct attribute_group *grp)
 {
-- 
1.5.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] remove duplicate definition of sysfs_update_group()
  2008-05-04 14:17 [PATCH 1/1] remove duplicate definition of sysfs_update_group() Dmitri Vorobiev
@ 2008-05-04 22:08 ` Dmitri Vorobiev
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitri Vorobiev @ 2008-05-04 22:08 UTC (permalink / raw)
  To: Dmitri Vorobiev; +Cc: gregkh, linux-kernel, Ingo Molnar

Dmitri Vorobiev пишет:
> The stub version of the sysfs_update_group() function is erroneously
> provided twice. This patch removes the redundant definition.
> 

Oops! I did not notice Ingo's fix when I was sending my patch:

http://lkml.org/lkml/2008/5/4/21

In Ingo's version, the changelog entry is much better than mine. Sorry
for the noise.

Dmitri

> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
> ---
>  include/linux/sysfs.h |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> index 27bad59..7858eac 100644
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -196,12 +196,6 @@ static inline int sysfs_update_group(struct kobject *kobj,
>  	return 0;
>  }
>  
> -static inline int sysfs_update_group(struct kobject *kobj,
> -				const struct attribute_group *grp)
> -{
> -	return 0;
> -}
> -
>  static inline void sysfs_remove_group(struct kobject *kobj,
>  				      const struct attribute_group *grp)
>  {


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-04 22:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-04 14:17 [PATCH 1/1] remove duplicate definition of sysfs_update_group() Dmitri Vorobiev
2008-05-04 22:08 ` Dmitri Vorobiev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox