From: Eric Sandeen <sandeen@sandeen.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH] i386: Execute stack overflow warning on interrupt stack II
Date: Mon, 05 May 2008 08:13:38 -0500 [thread overview]
Message-ID: <481F0802.4000608@sandeen.net> (raw)
In-Reply-To: <alpine.LFD.1.10.0805051434200.3318@apollo.tec.linutronix.de>
Thomas Gleixner wrote:
> On Mon, 5 May 2008, Andi Kleen wrote:
>> Thomas Gleixner wrote:
>>> On Fri, 2 May 2008, Andi Kleen wrote:
>>>> +static void stack_overflow(void)
>>>> +{
>>>> + printk("low stack detected by irq handler\n");
>>> Needs a KERN_ERR
>> Just moving code. If there is one added it should be in another patch.
>
> Err, you are not moving code. The printk is pretty different and
> adding the KERN_xx in the same go is nothing which makes the patch
> harder to understand.
>
>> Besides if anything it's a KERN_WARN I guess.
>
> KERN_WARN is fine, even if I consider a stack overflow as an error.
But it hasn't overflowed yet. It's a warning about being *close* - not
an error.
-Eric
next prev parent reply other threads:[~2008-05-05 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 9:18 [PATCH] i386: Execute stack overflow warning on interrupt stack Andi Kleen
2008-05-02 9:45 ` Jiri Slaby
2008-05-02 9:48 ` Andi Kleen
2008-05-02 9:45 ` [PATCH] i386: Execute stack overflow warning on interrupt stack II Andi Kleen
2008-05-05 9:59 ` Thomas Gleixner
2008-05-05 10:17 ` Andi Kleen
2008-05-05 12:39 ` Thomas Gleixner
2008-05-05 13:13 ` Eric Sandeen [this message]
2008-05-05 13:29 ` Andi Kleen
2008-05-05 13:42 ` Pekka Enberg
2008-05-05 13:45 ` Andi Kleen
2008-05-05 13:42 ` [PATCH] i386: Execute stack overflow warning on interrupt stack Eric Sandeen
2008-05-05 13:47 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481F0802.4000608@sandeen.net \
--to=sandeen@sandeen.net \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox