From: Andi Kleen <andi@firstfloor.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, mingo@elte.hu, sandeen@sandeen.net
Subject: Re: [PATCH] i386: Execute stack overflow warning on interrupt stack II
Date: Mon, 05 May 2008 15:45:42 +0200 [thread overview]
Message-ID: <481F0F86.50009@firstfloor.org> (raw)
In-Reply-To: <84144f020805050642p1e0ca224r9c1a92e899fddfe3@mail.gmail.com>
Pekka Enberg wrote:
> Hi Andi,
>
> On Mon, May 5, 2008 at 4:29 PM, Andi Kleen <andi@firstfloor.org> wrote:
>> > Err, it checks the process stack when 4KSTACKS=n
>>
>> Ok then please add the two changes if you feel strongly about that
>> (to the latest version I sent).
>>
>> You always edit my patches anyways (usually driving me crazy when I have
>> dependent patches because nothing applies anymore when all the variables
>> got renamed like you often do) so I don't see any reason why you can't
>> do that here.
>
> Heh, do you mean to say that all this time I should have just asked
> Andrew to fix all the patches I've submitted rather take the trouble
> to do that myself after the review? ;-)
It is quite ok for trivial changes (like adding KERN_WARN or unlikely).
And yes Andrew does this all the time too. It makes sense because for
such trivialities it is less work to just change the patch than to comment.
-Andi
next prev parent reply other threads:[~2008-05-05 13:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 9:18 [PATCH] i386: Execute stack overflow warning on interrupt stack Andi Kleen
2008-05-02 9:45 ` Jiri Slaby
2008-05-02 9:48 ` Andi Kleen
2008-05-02 9:45 ` [PATCH] i386: Execute stack overflow warning on interrupt stack II Andi Kleen
2008-05-05 9:59 ` Thomas Gleixner
2008-05-05 10:17 ` Andi Kleen
2008-05-05 12:39 ` Thomas Gleixner
2008-05-05 13:13 ` Eric Sandeen
2008-05-05 13:29 ` Andi Kleen
2008-05-05 13:42 ` Pekka Enberg
2008-05-05 13:45 ` Andi Kleen [this message]
2008-05-05 13:42 ` [PATCH] i386: Execute stack overflow warning on interrupt stack Eric Sandeen
2008-05-05 13:47 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481F0F86.50009@firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=sandeen@sandeen.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox