* Re: [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only
2008-05-05 15:24 [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only Peter Oberparleiter
@ 2008-05-05 19:55 ` Sam Ravnborg
2008-05-06 15:53 ` Peter Oberparleiter
2008-05-06 4:20 ` Andrew Morton
2008-05-06 7:36 ` Jan Engelhardt
2 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2008-05-05 19:55 UTC (permalink / raw)
To: Peter Oberparleiter; +Cc: linux-kernel, ltp-list, ltp-coverage, Andrew Morton
On Mon, May 05, 2008 at 05:24:16PM +0200, Peter Oberparleiter wrote:
> From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
> Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
> ---
> scripts/Kbuild.include | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.26-rc1/scripts/Kbuild.include
> ===================================================================
> --- linux-2.6.26-rc1.orig/scripts/Kbuild.include
> +++ linux-2.6.26-rc1/scripts/Kbuild.include
> @@ -144,7 +144,7 @@ ld-option = $(call try-run,\
> build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj
>
> # Prefix -I with $(srctree) if it is not an absolute path.
> -addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)
> +addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))
>
> # Find all -I options and call addtree
> flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o)))
We try to make all paths relative so less files get rebuild if you access the
same source from two different paths (think nfs mounted src etc).
So you really need to justify this change.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only
2008-05-05 19:55 ` Sam Ravnborg
@ 2008-05-06 15:53 ` Peter Oberparleiter
0 siblings, 0 replies; 6+ messages in thread
From: Peter Oberparleiter @ 2008-05-06 15:53 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: ltp-list, Andrew Morton, ltp-coverage, linux-kernel
Sam Ravnborg wrote:
> On Mon, May 05, 2008 at 05:24:16PM +0200, Peter Oberparleiter wrote:
>> From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
>> Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
>> ===================================================================
>> --- linux-2.6.26-rc1.orig/scripts/Kbuild.include
>> +++ linux-2.6.26-rc1/scripts/Kbuild.include
>> @@ -144,7 +144,7 @@ ld-option = $(call try-run,\
>> build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj
>>
>> # Prefix -I with $(srctree) if it is not an absolute path.
>> -addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)
>> +addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))
>>
>> # Find all -I options and call addtree
>> flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o)))
>
> We try to make all paths relative so less files get rebuild if you access the
> same source from two different paths (think nfs mounted src etc).
> So you really need to justify this change.
I understand your point about keeping as many paths as possible relative
and would like to discuss that in the reply to patch 3, where most
changes towards absolute paths are done.
As for this patch: on second thought I think this change makes no sense
without the next patch - I'll have to redo them both.
Regards,
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only
2008-05-05 15:24 [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only Peter Oberparleiter
2008-05-05 19:55 ` Sam Ravnborg
@ 2008-05-06 4:20 ` Andrew Morton
2008-05-06 7:36 ` Jan Engelhardt
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2008-05-06 4:20 UTC (permalink / raw)
To: Peter Oberparleiter; +Cc: linux-kernel, ltp-list, ltp-coverage, sam
On Mon, 05 May 2008 17:24:16 +0200 Peter Oberparleiter <peter.oberparleiter@de.ibm.com> wrote:
> From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
> Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
> ---
> scripts/Kbuild.include | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.26-rc1/scripts/Kbuild.include
> ===================================================================
> --- linux-2.6.26-rc1.orig/scripts/Kbuild.include
> +++ linux-2.6.26-rc1/scripts/Kbuild.include
> @@ -144,7 +144,7 @@ ld-option = $(call try-run,\
> build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj
>
> # Prefix -I with $(srctree) if it is not an absolute path.
> -addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)
> +addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))
>
> # Find all -I options and call addtree
> flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o)))
>
-ENOCHANGLEOG. What is the reason for this change?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only
2008-05-05 15:24 [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only Peter Oberparleiter
2008-05-05 19:55 ` Sam Ravnborg
2008-05-06 4:20 ` Andrew Morton
@ 2008-05-06 7:36 ` Jan Engelhardt
2008-05-06 18:38 ` Peter Oberparleiter
2 siblings, 1 reply; 6+ messages in thread
From: Jan Engelhardt @ 2008-05-06 7:36 UTC (permalink / raw)
To: Peter Oberparleiter
Cc: linux-kernel, ltp-list, ltp-coverage, Andrew Morton, sam
On Monday 2008-05-05 17:24, Peter Oberparleiter wrote:
>+++ linux-2.6.26-rc1/scripts/Kbuild.include
>@@ -144,7 +144,7 @@ ld-option = $(call try-run,\
> build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj
>
> # Prefix -I with $(srctree) if it is not an absolute path.
>-addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)
>+addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))
At least make it so that relative can be used whenever possible (e.g. on
!CONFIG_GCOV)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only
2008-05-06 7:36 ` Jan Engelhardt
@ 2008-05-06 18:38 ` Peter Oberparleiter
0 siblings, 0 replies; 6+ messages in thread
From: Peter Oberparleiter @ 2008-05-06 18:38 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: ltp-list, Andrew Morton, ltp-coverage, sam, linux-kernel
Jan Engelhardt wrote:
> On Monday 2008-05-05 17:24, Peter Oberparleiter wrote:
>>+++ linux-2.6.26-rc1/scripts/Kbuild.include
>>@@ -144,7 +144,7 @@ ld-option = $(call try-run,\
>> build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj
>>
>> # Prefix -I with $(srctree) if it is not an absolute path.
>>-addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)
>>+addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))
>
> At least make it so that relative can be used whenever possible (e.g. on
> !CONFIG_GCOV)
Good idea - I'll consider it for the next patch version.
Regards,
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread