From: Rene Herman <rene.herman@keyaccess.nl>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Uwe Bugla <uwe.bugla@gmx.de>, Takashi Iwai <tiwai@suse.de>,
Len Brown <len.brown@intel.com>, Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] PNP: add pnp_build_option() to the API
Date: Tue, 06 May 2008 03:08:15 +0200 [thread overview]
Message-ID: <481FAF7F.3020406@keyaccess.nl> (raw)
In-Reply-To: <481FAC37.6090703@keyaccess.nl>
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
Hi Bjorn.
The subsequent AD181x quirk patch would like this as part of the API.
pnp_register_dependent_option() adds to the same dependent chain the
quirk is walking which is fairly unclean. This enables a private
option chain build which it can then just add onto the end when done.
Signed-off-by: Rene Herman <rene.herman@gmail.com>
[-- Attachment #2: pnp-add-pnp_build_option-to-the-api.diff --]
[-- Type: text/plain, Size: 1532 bytes --]
commit 1e16678158431ad9260acbd9ff3e43468b67ab6d
Author: Rene Herman <rene.herman@gmail.com>
Date: Tue May 6 01:54:43 2008 +0200
PNP: add pnp_build_option() to the API
The subsequent AD181x quirk patch would like this as part of the API.
pnp_register_dependent_option() adds to the same dependent chain the
quirk is walking which is fairly unclean. This enables a private
option chain build which it can then just add onto the end when done.
Signed-off-by: Rene Herman <rene.herman@gmail.com>
diff --git a/drivers/pnp/base.h b/drivers/pnp/base.h
index 4fe7c58..886dac8 100644
--- a/drivers/pnp/base.h
+++ b/drivers/pnp/base.h
@@ -19,6 +19,7 @@ void pnp_remove_card(struct pnp_card *card);
int pnp_add_card_device(struct pnp_card *card, struct pnp_dev *dev);
void pnp_remove_card_device(struct pnp_dev *dev);
+struct pnp_option *pnp_build_option(int priority);
struct pnp_option *pnp_register_independent_option(struct pnp_dev *dev);
struct pnp_option *pnp_register_dependent_option(struct pnp_dev *dev,
int priority);
diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
index 2041620..390b500 100644
--- a/drivers/pnp/resource.c
+++ b/drivers/pnp/resource.c
@@ -28,7 +28,7 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 }; /* reserve (don't use) some
* option registration
*/
-static struct pnp_option *pnp_build_option(int priority)
+struct pnp_option *pnp_build_option(int priority)
{
struct pnp_option *option = pnp_alloc(sizeof(struct pnp_option));
next parent reply other threads:[~2008-05-06 1:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <481FAC37.6090703@keyaccess.nl>
2008-05-06 1:08 ` Rene Herman [this message]
[not found] ` <481FAD12.3030409@keyaccess.nl>
2008-05-06 1:08 ` [PATCH 3/3] PNP: add AD1815 and AD1816 quirks Rene Herman
2008-05-06 19:08 ` Bjorn Helgaas
2008-05-06 21:06 ` Rene Herman
2008-05-06 21:27 ` Bjorn Helgaas
2008-05-06 22:01 ` Rene Herman
2008-05-07 2:14 ` Rene Herman
2008-05-06 1:08 [PATCH 1/3] PNP: cleanup pnp_fixup_device() Rene Herman
2008-05-06 17:15 ` Bjorn Helgaas
[not found] ` <482614B3.4000908@gmail.com>
2008-05-10 21:48 ` [PATCH 2/3] PNP: add pnp_build_option() to the API Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481FAF7F.3020406@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=uwe.bugla@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox