Re: [PATCH] Microblaze: implement dma-coherent API and refactor cache flush code.

Michal Simek
2008-05-06T09:30:17Z

Hi Steve,

> arch/microblaze/kernel/cpu/cache.c | 37 +---------
> arch/microblaze/kernel/setup.c | 4 +-
> arch/microblaze/mm/dma-coherent.c | 122

dma-coherent.c is dead for now.

> diff --git a/arch/microblaze/kernel/setup.c
> b/arch/microblaze/kernel/setup.c
> index 43d53d9..241fb21 100644
> --- a/arch/microblaze/kernel/setup.c
> +++ b/arch/microblaze/kernel/setup.c
> @@ -51,10 +51,10 @@ void __init setup_arch(char **cmdline_p)
> /* irq_early_init(); */
> setup_cpuinfo();
>
> - __flush_icache_all();
> + __invalidate_icache_all();
> __enable_icache();
>
> - __flush_dcache_all();
> + __invalidate_icache_all();
> __enable_dcache();

here is bug.

> panic_timeout = 120;
> diff --git a/arch/microblaze/mm/dma-coherent.c
> b/arch/microblaze/mm/dma-coherent.c

removed.

M