public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: ltp-list@lists.sourceforge.net,
	Rusty Russell <rusty@rustcorp.com.au>,
	ltp-coverage@lists.sourceforge.net, sam@ravnborg.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/6] kernel: call constructors
Date: Tue, 06 May 2008 13:56:22 +0200	[thread overview]
Message-ID: <48204766.7020506@de.ibm.com> (raw)
In-Reply-To: <20080505211942.3945d01c.akpm@linux-foundation.org>

Andrew Morton wrote:
> On Mon, 05 May 2008 17:24:04 +0200 Peter Oberparleiter <peter.oberparleiter@de.ibm.com> wrote:
> 
>> From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
>> --- linux-2.6.26-rc1.orig/arch/powerpc/kernel/vmlinux.lds.S
>> +++ linux-2.6.26-rc1/arch/powerpc/kernel/vmlinux.lds.S
>> @@ -193,6 +193,9 @@ SECTIONS
>>  		*(.toc)
>>  	}
>>  #endif
>> +	.data.gcov : {
>> +		CONSTRUCTORS
>> +	}
> 
> Why did powerpc (and only powerpc) need this touchup?  It already includes
> asm-generic/vmlinux.lds.h?

asm-generic/vmlinux.lds.h defines CONSTRUCTORS but it needs to be
referenced in the actual linker script to become active. For some reason
unknown to me, CONSTRUCTORS shows up in all arch/*/vmlinux.lds.S scripts
except for powerpc (see also my other reply about the CONSTRUCTORS
section).

      reply	other threads:[~2008-05-06 11:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 15:24 [RFC PATCH 1/6] kernel: call constructors Peter Oberparleiter
2008-05-05 19:53 ` Sam Ravnborg
2008-05-06 11:50   ` Peter Oberparleiter
2008-05-06  4:19 ` Andrew Morton
2008-05-06 11:56   ` Peter Oberparleiter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48204766.7020506@de.ibm.com \
    --to=peter.oberparleiter@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltp-coverage@lists.sourceforge.net \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox