[2.6 patch] make mm/memory_hotplug.c:online_page() static

[2.6 patch] make mm/memory_hotplug.c:online_page() static

[Adrian Bunk]

Now that it's in the same file as it's caller online_page() can become 
static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 include/linux/memory_hotplug.h |    2 --
 mm/memory_hotplug.c            |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

81106e4532f244cd20b40e856c2f6d21774a55fc diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
index 73e3586..5ca2325 100644
--- a/include/linux/memory_hotplug.h
+++ b/include/linux/memory_hotplug.h
@@ -64,8 +64,6 @@ static inline void zone_seqlock_init(struct zone *zone)
 extern int zone_grow_free_lists(struct zone *zone, unsigned long new_nr_pages);
 extern int zone_grow_waitqueues(struct zone *zone, unsigned long nr_pages);
 extern int add_one_highpage(struct page *page, int pfn, int bad_ppro);
-/* need some defines for these for archs that don't support it */
-extern void online_page(struct page *page);
 /* VM interface that may be used by firmware interface */
 extern int online_pages(unsigned long, unsigned long);
 extern void __offline_isolated_pages(unsigned long, unsigned long);
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index b17dca7..b3fd604 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -329,7 +329,7 @@ static void grow_pgdat_span(struct pglist_data *pgdat,
 					pgdat->node_start_pfn;
 }
 
-void online_page(struct page *page)
+static void online_page(struct page *page)
 {
 	totalram_pages++;
 	num_physpages++;

Re: [2.6 patch] make mm/memory_hotplug.c:online_page() static

[Jeremy Fitzhardinge]

Adrian Bunk wrote:
> Now that it's in the same file as it's caller online_page() can become 
> static.
>   

I have a patch to call it from elsewhere, so I'd like to keep it as a 
kernel-internal API for now.

    J