From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765977AbYEFQxA (ORCPT ); Tue, 6 May 2008 12:53:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761163AbYEFQwo (ORCPT ); Tue, 6 May 2008 12:52:44 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:45838 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760626AbYEFQwm (ORCPT ); Tue, 6 May 2008 12:52:42 -0400 Message-ID: <48208CEC.2090200@bull.net> Date: Tue, 06 May 2008 18:53:00 +0200 From: Benjamin Thery User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: "Serge E. Hallyn" Cc: Daniel Lezcano , "Eric W. Biederman" , Greg KH , linux-kernel@vger.kernel.org, Al Viro , Tejun Heo , Pavel Emelyanov , netdev@vger.kernel.org Subject: Re: [PATCH 00/10] sysfs tagged directories References: <20080429180445.GA18110@sergelap.austin.ibm.com> <20080429184151.GA19794@suse.de> <20080429193417.GA19282@sergelap.austin.ibm.com> <20080501031341.GD4911@suse.de> <20080501151051.GB16038@sergelap.austin.ibm.com> <20080501210550.GA22534@sergelap.austin.ibm.com> <20080502174222.GA16493@sergelap.austin.ibm.com> <481E4312.9060909@fr.ibm.com> <20080505161800.GC8485@sergelap.austin.ibm.com> In-Reply-To: <20080505161800.GC8485@sergelap.austin.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Serge E. Hallyn wrote: > Quoting Daniel Lezcano (dlezcano@fr.ibm.com): >> Serge E. Hallyn wrote: >>> Quoting Eric W. Biederman (ebiederm@xmission.com): >>>> "Serge E. Hallyn" writes: >>>> >>>>> Quoting Eric W. Biederman (ebiederm@xmission.com): >>>>> Ok as it turns out Benjamin Thery does in fact have a patch to fix this. >>>>> Benjamin, please send your renaming patch out tomorrow if you can? >>>>> >>>>> I guess this is why I didn't really see the problem Benjamin said there >>>>> was - it just works with SYSFS_DEPRECATED :) >>>> It will be nice to see that patch. I'm curious what the problem was. >>>> >>>> Eric >>> Here is the patch he had privately sent. As the comments indicate he's >>> still refining it so yell at me not him... but this on top of the >>> tagged dir patchset makes everything work for me. >>> (I'd *really* like to see network namespaces be generally usable sometime >>> in 2.6.26.) >> Serge, >> >> I posted a fix to Dave Miller which was included in net-2.6 and merged in >> 2.6.26-rc1. > > Cool, I see it in gitweb, thanks. > >> http://marc.info/?l=linux-netdev&m=120959135229360&w=2 >> >> This one should fix your problem for sysfs. >> >> There is another fix to do in order to avoid name conflicts with network >> interfaces belonging to different namespaces, eg. allows to rename veth1234 >> to eth0 without conflicting with the network device belonging in init_net, >> I send this patch to container@ first to have it merged with the sysfs >> patchset. > > Ok. > > Benjamin, what are you doing with Eric's sysfs patchset then? Are you > going to re-post it asap on top of whatever tree has these two patches, > or are you planning to wait longer? I will resend the patchset on top of 2.6.26-rc1, with Daniel's last patch merged. (If anyone prefer to have it merged on top of net-2.6, say so) -benjamin > > thanks, > -serge > > -- B e n j a m i n T h e r y - BULL/DT/Open Software R&D http://www.bull.com