public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: "Thomas Gleixner" <tglx@linutronix.de>
Cc: <odie@cs.aau.dk>, "Ingo Molnar" <mingo@elte.hu>,
	"Jeremy Fitzhardinge" <jeremy@goop.org>,
	"Chuck Ebbert" <cebbert@redhat.com>,
	<linux-kernel@vger.kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Please revert 709f744 (x86: bitops asm constraint fixes)
Date: Wed, 07 May 2008 08:50:23 +0100	[thread overview]
Message-ID: <48217B5F.76E4.0078.0@novell.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0805070940060.3318@apollo.tec.linutronix.de>

>>> Thomas Gleixner <tglx@linutronix.de> 07.05.08 09:43 >>>
>On Wed, 7 May 2008, Jan Beulich wrote:
>> >>> Ingo Molnar <mingo@elte.hu> 06.05.08 14:01 >>>
>> >Jan, any ideas what's wrong with your commit?
>> 
>> No, I have no idea at all (apart from considering mis-compilation as you
>> did. The best path I could suggest is to try and nail this down to one
>> (or more, if that happens to be the case) function(s) having been
>> changed - this is mostly because part of the changes are really
>> tightening things (which therefore I would think ought to be kept),
>> while the change to __test_and_change_bit() really weakens things
>> (which I nevertheless continue to think is correct and consistent with
>> other functions, but which then would be the primary suspect). Of
>> course, since no-one else has seen this so far, this would need to be
>> done by Simon.
>> Once down to a single (hopefully) function, it might be possible to just
>> statically compare the two vmlinux-es to perhaps spot whether this
>> indeed is mis-compilation.
>
>Jan,
>
>can you please provide a step by step conversion of those constraints
>on top of the revert. I'm a bit wary about this whole business as such
>constraint problems might hit us elsewhere as well.

I certainly can, but I can't promise when I'd get to do this (may be days
to weeks - sorry for that).

Jan


      reply	other threads:[~2008-05-07  7:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 13:45 Please revert 709f744 (x86: bitops asm constraint fixes) Simon Holm Thøgersen
2008-05-06 12:01 ` Ingo Molnar
2008-05-06 12:45   ` Simon Holm Thøgersen
2008-05-07  7:27   ` Jan Beulich
2008-05-07  7:43     ` Thomas Gleixner
2008-05-07  7:50       ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48217B5F.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=cebbert@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=odie@cs.aau.dk \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox