Re: [PATCH 11/12] isdn: use the common ascii hex helpers

[Tilman Schmidt <tilman@imap.cc>]

[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]

On 02.05.2008 21:01, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>

Thanks,
Tilman

> ---
>  drivers/isdn/gigaset/isocdata.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/isdn/gigaset/isocdata.c b/drivers/isdn/gigaset/isocdata.c
> index e30a777..fbce522 100644
> --- a/drivers/isdn/gigaset/isocdata.c
> +++ b/drivers/isdn/gigaset/isocdata.c
> @@ -247,7 +247,6 @@ static inline void dump_bytes(enum debuglevel level, const char *tag,
>  #ifdef CONFIG_GIGASET_DEBUG
>  	unsigned char c;
>  	static char dbgline[3 * 32 + 1];
> -	static const char hexdigit[] = "0123456789abcdef";
>  	int i = 0;
>  	while (count-- > 0) {
>  		if (i > sizeof(dbgline) - 4) {
> @@ -258,8 +257,8 @@ static inline void dump_bytes(enum debuglevel level, const char *tag,
>  		c = *bytes++;
>  		dbgline[i] = (i && !(i % 12)) ? '-' : ' ';
>  		i++;
> -		dbgline[i++] = hexdigit[(c >> 4) & 0x0f];
> -		dbgline[i++] = hexdigit[c & 0x0f];
> +		dbgline[i++] = hex_asc_hi(c);
> +		dbgline[i++] = hex_asc_lo(c);
>  	}
>  	dbgline[i] = '\0';
>  	gig_dbg(level, "%s:%s", tag, dbgline);


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]