Re: 2.6.26, PAT and AMD family 6

[Rene Herman <rene.herman@keyaccess.nl>]

On 07-05-08 22:52, Thomas Gleixner wrote:

>> And why do we need this clear_cpu_cap(c, X86_FEATURE_PAT) and then 
>> manual setting of X86_FEATURE_PAT at all?
> 
> The reason is to make cpu_has_pat a useful check and to avoid checking
> cpu vendors, families and models inside of the PAT code. That's a good
> thing actually, because the PAT code only cares about that cpu_has_pat
> flag.
> 
> Clearing it in the cpuinfo is just a cosmetic side effect which does
> no harm at all.

Oh yes, it does. It makes people unaware that their CPUs _should_ be
supporting PAT. The thing's not called /proc/kernelinfo for a reason.

>> And this patch (by the author of the code himself) is the first time 
>> where it breaks.
> 
> Very interesting analysis. What broke ? This CPU was never in the set
> of supported ones at all.

You misunderstood. Yinghai's patch only changed one of the code sites
and not the others, which (if I understood right) is the breakage
Adrian was reffering to.

> Anyway, you are welcome to review x86 code - it can definitely use 
> more eyeballs, but please try to inform yourself about the topic or 
> ask polite questions before yelling at people who contribute in a 
> very valuable way.

And would yelling at people how shuffle in code without (publicly at
least) addressing one of your fellow arch maintainers objections and
Pavel's review comments about code duplication without a single line
of explanation/changelog do?

Rene.