Re: 2.6.26, PAT and AMD family 6

[Rene Herman <rene.herman@keyaccess.nl>]

On 08-05-08 00:57, H. Peter Anvin wrote:

>>> Clearing it in the cpuinfo is just a cosmetic side effect which does
>>> no harm at all.
>>
>> Oh yes, it does. It makes people unaware that their CPUs _should_ be
>> supporting PAT. The thing's not called /proc/kernelinfo for a reason.
>>
> 
> Okay, that is utter nonsense.  /proc/cpuinfo has always been, and will 
> always be, the CPU *AS THE KERNEL SEES IT*.  If you want something else, 
> use x86info(1).

What a lovely way of syncing reality with your definitions. The kernel
_does_ see that my CPU features PAT, it just refuses to use it because
it doesn't trust it enough. Vital difference. Maybe not to the kernel,
but definitely to me, the user. /proc/cpuinfo is a user interface.

PAT is a CPU, hardware, flag documented in the arch manuals. If the
kernel wants to keep software flags as well why not simply add those?

>> And would yelling at people how shuffle in code without (publicly at
>> least) addressing one of your fellow arch maintainers objections and
>> Pavel's review comments about code duplication without a single line
>> of explanation/changelog do?
> 
> We did discuss this (over IRC, I'm afraid), and came to the conclusion 
> that it's too risky to do the proper thing (blacklist) straight out the 
> gate.  Consider it a staged implementation.  The reason for this is that 
> some of the earlier chips have downright frightening errata w.r.t. PAT. 
>  *At this point*, we'd have no reasonable way to filter those bug 
> reports from the issues with the software itself.
> 
> So, one step at a time.  PAT is massively overdue in Linux, so it's no 
> wonder you're anxious about it, but we need a modicum of caution here.

Really, I'm not so much anxious about PAT as I got anxious about seeing
my entire CPU famility dropped without a single explanation. Had the one
you provide above be in the commit message this thread had not happened
(yes, although redefining X86_FEATURE_PAT is still crap).

As it's merged, nothing said that it was specifically not using and/or
disabling PAT just that it wasn't supported. Even if it had done _that_
much this thread would've probably not happened.

Rene.