public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Newall <davidn@davidnewall.com>
To: Soumyadip Das Mahapatra <dip_kernel@yahoo.co.in>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: improved strnicmp in lib/string.c
Date: Thu, 08 May 2008 10:44:31 +0930	[thread overview]
Message-ID: <482253F7.7070501@davidnewall.com> (raw)
In-Reply-To: <116786.40929.qm@web94104.mail.in2.yahoo.com>

Soumyadip Das Mahapatra wrote:
> This is somewhat improved version of strnicmp() function in lib/string.c. I have implemented binary
> comparison  rather than linear one(which was in the older version).

It doesn't correctly indicate the sort order.  For example, when
comparing "accdd" against "abcde", it indicates that the first string
sorts before the second (which is wrong.)

      parent reply	other threads:[~2008-05-08  1:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07 18:21 [PATCH]: improved strnicmp in lib/string.c Soumyadip Das Mahapatra
2008-05-07 19:33 ` Pekka Enberg
2008-05-07 19:53 ` Alexey Dobriyan
2008-05-08  1:14 ` David Newall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482253F7.7070501@davidnewall.com \
    --to=davidn@davidnewall.com \
    --cc=dip_kernel@yahoo.co.in \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox