public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Raúl Porcel" <armin76@gentoo.org>
To: David Miller <davem@davemloft.net>
Cc: mikpe@it.uu.se, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] 2.6.26-rc1 hangs during boot on UltraSPARC 5
Date: Thu, 08 May 2008 12:33:29 +0200	[thread overview]
Message-ID: <4822D6F9.8090202@gentoo.org> (raw)
In-Reply-To: <20080506.152042.91330094.davem@davemloft.net>

David Miller wrote:
> From: Mikael Pettersson <mikpe@it.uu.se>
> Date: Tue, 6 May 2008 21:38:24 +0200
> 
>> I removed "| CON_BOOT" and got what looks like the same oops
>> Raúl Porcel reported earlier today (which he for some reason
>> sent only to the lists, not to you or me); his oops was:
> 
> I can reproduce this problem here in my t1000.
> 
> It looks like some kind of initrd regression.
> 
> Looking at the crashes, the kernel seems to be trying
> to dereference a physical address when peeking at the
> initrd instead of using a virtual one.  That's a big
> clue.
> 
> This patch should fix it:
> 
> commit d45100f7b69e3d9cd0cd5e956b6ac2c78d460d07
> Author: David S. Miller <davem@davemloft.net>
> Date:   Tue May 6 15:19:54 2008 -0700
> 
>     sparc64: Fix initrd regression.
>     
>     We die because we forget to convert initrd_start and
>     initrd_end to virtual addresses.
>     
>     Reported by Mikael Pettersson
>     
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/arch/sparc64/mm/init.c b/arch/sparc64/mm/init.c
> index db8e7fb..ec3e2c7 100644
> --- a/arch/sparc64/mm/init.c
> +++ b/arch/sparc64/mm/init.c
> @@ -771,6 +771,9 @@ static void __init find_ramdisk(unsigned long phys_base)
>  		initrd_end = ramdisk_image + sparc_ramdisk_size;
>  
>  		lmb_reserve(initrd_start, initrd_end);
> +
> +		initrd_start += PAGE_OFFSET;
> +		initrd_end += PAGE_OFFSET;
>  	}
>  #endif
>  }
> 

That fixed it for me as well, thanks!

      parent reply	other threads:[~2008-05-08 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06  7:54 [BUG] 2.6.26-rc1 hangs during boot on UltraSPARC 5 Mikael Pettersson
2008-05-06  8:05 ` David Miller
2008-05-06 13:10   ` Raúl Porcel
2008-05-06 19:38   ` Mikael Pettersson
2008-05-06 22:20     ` David Miller
2008-05-07 18:23       ` Mikael Pettersson
2008-05-08 10:33       ` Raúl Porcel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4822D6F9.8090202@gentoo.org \
    --to=armin76@gentoo.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox