From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763188AbYEHOgG (ORCPT ); Thu, 8 May 2008 10:36:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761191AbYEHOft (ORCPT ); Thu, 8 May 2008 10:35:49 -0400 Received: from E23SMTP04.au.ibm.com ([202.81.18.173]:38763 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761491AbYEHOfr (ORCPT ); Thu, 8 May 2008 10:35:47 -0400 Message-ID: <48230FBB.20105@linux.vnet.ibm.com> Date: Thu, 08 May 2008 20:05:39 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com Organization: IBM User-Agent: Thunderbird 2.0.0.14 (X11/20080505) MIME-Version: 1.0 To: Paul Menage CC: linux-mm@kvack.org, Sudhir Kumar , YAMAMOTO Takashi , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, David Rientjes , Pavel Emelianov , Andrew Morton , KAMEZAWA Hiroyuki Subject: Re: [-mm][PATCH 3/4] Add rlimit controller accounting and control References: <20080503213726.3140.68845.sendpatchset@localhost.localdomain> <20080503213814.3140.66080.sendpatchset@localhost.localdomain> <6599ad830805062029m37b507dcue737e1affddeb120@mail.gmail.com> In-Reply-To: <6599ad830805062029m37b507dcue737e1affddeb120@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Menage wrote: > On Sat, May 3, 2008 at 2:38 PM, Balbir Singh wrote: >> >> This patch adds support for accounting and control of virtual address space >> limits. The accounting is done via the rlimit_cgroup_(un)charge_as functions. >> The core of the accounting takes place during fork time in copy_process(), >> may_expand_vm(), remove_vma_list() and exit_mmap(). There are some special >> cases that are handled here as well (arch/ia64/kernel/perform.c, >> arch/x86/kernel/ptrace.c, insert_special_mapping()) >> > > The basic idea of the patches looks fine (apart from some > synchronization issues) but Is calling this the "rlimit" controller a > great idea? That implies that it handles all (or at least many) of the > things that setrlimit()/getrlimit() handle. > > While some of the other rlimit things definitely do make sense as > cgroup controllers, putting them all in the same controller doesn't > really - paying for the address-space tracking overhead just to get, > say, the equivalent of RLIMIT_NPROC (max tasks) isn't a great idea. > > Can you instead give this a name that somehow refers to virtual > address space limits, e.g. "va" or "as". That would still fit if you > expanded it to deal with locked virtual address space limits too. > > I think that an "rlimit" controller would probably be best for > representing just those limits that don't really make sense when > aggregated across different tasks, but apply separately to each task > (e.g. RLIMIT_FSIZE, RLIMIT_CORE, RLIMIT_NICE, RLIMIT_NOFILE, > RLIMIT_RTPRIO, RLIMIT_STACK, RLIMIT_SIGPENDING, and maybe RLIMIT_CPU), > in order to provide an easy way to change these limits on a group of > running tasks. > I currently intend to use this controller for controlling memory related rlimits, like address space and mlock'ed memory. How about we use something like "memrlimit"? > On a separate note for the address-space tracking, ideally the > subsystem would track whether or not it was bound to a hierarchy, and > skip charging/uncharging if not. That way there's no (noticeable) > overhead for compiling in the subsystem but not using it. At the point > when the subsystem was bound to a hierarchy, it could at that point > run through all mms and charge each one's existing address space to > the appropriate cgroup. (Currently that would only be the root cgroup > in the hierarchy). Good suggestion, but it will be hard if not impossible to account the data correctly as it changes, if we do the accounting/summation at bind time. We'll need a really big lock to do it, something I want to avoid. Did you have something else in mind? -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL