From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1764709AbYEHQpf@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1764709AbYEHQpf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 8 May 2008 12:45:35 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756048AbYEHQpZ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 8 May 2008 12:45:25 -0400
Received: from terminus.zytor.com ([198.137.202.10]:35788 "EHLO
	terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755808AbYEHQpX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 8 May 2008 12:45:23 -0400
Message-ID: <48232DFB.1030703@zytor.com>
Date: Thu, 08 May 2008 09:44:43 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.12 (X11/20080226)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: Thomas Gleixner <tglx@linutronix.de>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Rene Herman <rene.herman@keyaccess.nl>, Adrian Bunk <bunk@kernel.org>,
       Yinghai Lu <yhlu.kernel@gmail.com>,
       Linux Kernel <linux-kernel@vger.kernel.org>, akpm@linux-foundation.org,
       Pavel Machek <pavel@suse.cz>
Subject: Re: [PATCH] x86: introduce a new Linux defined feature flag for	PAT
 support
References: <48224361.5080102@zytor.com> <48224507.8010102@keyaccess.nl> <alpine.LFD.1.10.0805071716060.3024@woody.linux-foundation.org> <48224930.9030901@keyaccess.nl> <48225DEC.2030502@keyaccess.nl> <alpine.LFD.1.10.0805071857430.3024@woody.linux-foundation.org> <4822614B.6080706@zytor.com> <alpine.LFD.1.10.0805071923030.3024@woody.linux-foundation.org> <48226569.7010906@zytor.com> <alpine.LFD.1.10.0805081307520.3318@apollo.tec.linutronix.de> <20080508130838.GA13162@elte.hu>
In-Reply-To: <20080508130838.GA13162@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
> 
>> Subject: x86: cleanup PAT cpu validation
>> From: Thomas Gleixner <tglx@linutronix.de>
>> Date: Thu, 08 May 2008 09:18:43 +0200
>>
>> Move the scattered checks for PAT support to a single function. Its 
>> moved to addon_cpuid_features.c as this file is shared between 32 and 
>> 64 bit.
> 
> thanks Thomas, i have applied your cleanup patch - looks good here too 
> and it booted fine on a few boxes.
> 
> (i did a small cleanup: changed the define to static const int)
> 
> Peter, what are your plans for a more general cleanup and 32-bit/64-bit 
> unification for the x86 CPU detection code - do you have any specific 
> ideas already? I suspect we want it all to end up unified under 
> arch/x86/kernel/cpu/, by moving the relevant bits of 
> arch/x86/kernel/setup_64.c there, right? It is no small task for sure.
> 

Yes, that's the plan, and no, it's not a small task.

	-hpa