From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932713AbYEHVcV (ORCPT ); Thu, 8 May 2008 17:32:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752726AbYEHVcA (ORCPT ); Thu, 8 May 2008 17:32:00 -0400 Received: from terminus.zytor.com ([198.137.202.10]:38752 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbYEHVb6 (ORCPT ); Thu, 8 May 2008 17:31:58 -0400 Message-ID: <4823705E.1040401@zytor.com> Date: Thu, 08 May 2008 14:27:58 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Venki Pallipadi CC: linux-kernel , Ingo Molnar , Thomas Gleixner , Suresh B Siddha , arjan@infradead.org, Andi Kleen Subject: Re: [PATCH] x86: Remove 6 bank limitation in 64 bit MCE reporting code References: <20080508211836.GA26353@linux-os.sc.intel.com> In-Reply-To: <20080508211836.GA26353@linux-os.sc.intel.com> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Venki Pallipadi wrote: > Eliminate the 6 bank restriction in 64 bit mce reporting code. This restriction > is artificial (due to static creation of sysfs files) and 32 bit code > does not have any such restriction. > > This change helps in reporting the details of machine checks on a machine check > exception with errors in bank 6 and above on CPUs that support those banks. > Without the patch, machine check errors in those banks are not reported. > > We still have 128 (MCE_EXTENDED_BANK) bank restriction instead of max 256 > supported in hardware. That is not changed in the patch below as it will have > some user level mcelog utility dependency, with bank 128 being used for > thermal reporting currently. > > The patch below does not create sysfs control (bankNctl) for banks higher > than 6 as well. That needs some pre-cleanup in /sysfs mce layout, removal of > per cpu /sysfs entries for bankctl as they are really global system level > control today. That change will follow. This basic change is critical to > report the detailed errors on banks higher than 6. > > Signed-off-by: Venkatesh Pallipadi Any chance you could add unifying the 32 and 64-bit code to your list, since you're already working on eliminating differences there? -hpa