From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
toralf.foerster@gmx.de, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mike Travis <travis@sgi.com>
Subject: Re: build issue #380 for v2.6.26-rc1-279-g28a4acb : mach-voyager: multiple definition of `phys_cpu_present_map'
Date: Fri, 09 May 2008 19:01:15 +0400 [thread overview]
Message-ID: <4824673B.1030503@suse.de> (raw)
In-Reply-To: <20080509144722.GA20566@elte.hu>
Ingo Molnar wrote:
> * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
>>>> /* Bitmask of CPUs present in the system - exported by i386_syms.c, used
>>>> * by scheduler but indexed physically */
>>>> -cpumask_t phys_cpu_present_map = CPU_MASK_NONE;
>>>> +static cpumask_t phys_cpu_present_map = CPU_MASK_NONE;
>>> i've got the one below queued up but it's stalled as it could easily be
>>> wrong and there's no ack from James yet and there's been discussion back
>>> and forth. James, what do you suggest?
>
>> I already told you that this was incorrect. This is what I sent as
>> the replacement on 28 April and I didn't hear back from you.
>>
>> http://marc.info/?l=linux-kernel&m=120941111400620
>
> ok - picked it up for testing - could you please send a signoff line as
> well?
>
> Alexey, you moved those SMP variables, do you agree with the patch from
> James? (it looks good to me)
Yes, they look good to me as well.
Alex.
next prev parent reply other threads:[~2008-05-09 15:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 9:13 build issue #380 for v2.6.26-rc1-279-g28a4acb : mach-voyager: multiple definition of `phys_cpu_present_map' Toralf Förster
2008-05-09 9:30 ` WANG Cong
2008-05-09 9:58 ` Toralf Förster
2008-05-09 10:16 ` WANG Cong
2008-05-09 9:52 ` WANG Cong
2008-05-09 9:58 ` Ingo Molnar
2008-05-09 10:09 ` WANG Cong
2008-05-09 10:59 ` Toralf Förster
2008-05-09 11:22 ` WANG Cong
2008-05-09 14:22 ` James Bottomley
2008-05-09 14:47 ` Ingo Molnar
2008-05-09 15:01 ` Alexey Starikovskiy [this message]
2008-05-10 13:17 ` Ingo Molnar
2008-05-10 14:01 ` James Bottomley
2008-05-10 14:21 ` James Bottomley
2008-05-10 14:34 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4824673B.1030503@suse.de \
--to=astarikovskiy@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=toralf.foerster@gmx.de \
--cc=travis@sgi.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox