From: Pavan Bobba <opensource206@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Pavan Bobba <opensource206@gmail.com>
Subject: [PATCH 11/11] staging: vt6655: Type encoding info dropped from variable name "apTailTD"
Date: Tue, 31 Oct 2023 11:04:34 +0530 [thread overview]
Message-ID: <482553f089fe86dc7ebecd96c9397cfaa9c7bdf9.1698730318.git.opensource206@gmail.com> (raw)
In-Reply-To: <cover.1698730318.git.opensource206@gmail.com>
variable name "apTailTD" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
drivers/staging/vt6655/card.c | 4 ++--
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/device_main.c | 8 ++++----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index d20afbc1072f..36183f2a64c1 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -388,10 +388,10 @@ void card_safe_reset_tx(struct vnt_private *priv)
struct vnt_tx_desc *curr_td;
/* initialize TD index */
- priv->apTailTD[0] = &priv->apTD0Rings[0];
+ priv->tail_td[0] = &priv->apTD0Rings[0];
priv->apCurrTD[0] = &priv->apTD0Rings[0];
- priv->apTailTD[1] = &priv->apTD1Rings[0];
+ priv->tail_td[1] = &priv->apTD1Rings[0];
priv->apCurrTD[1] = &priv->apTD1Rings[0];
for (uu = 0; uu < TYPE_MAXTD; uu++)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index fadbfccf42de..0212240ba23f 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -133,7 +133,7 @@ struct vnt_private {
volatile int iTDUsed[TYPE_MAXTD];
struct vnt_tx_desc *apCurrTD[TYPE_MAXTD];
- struct vnt_tx_desc *apTailTD[TYPE_MAXTD];
+ struct vnt_tx_desc *tail_td[TYPE_MAXTD];
struct vnt_tx_desc *apTD0Rings;
struct vnt_tx_desc *apTD1Rings;
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index a1f3dc25ad0e..b0b262de6480 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -737,7 +737,7 @@ static int device_init_td0_ring(struct vnt_private *priv)
if (i > 0)
priv->apTD0Rings[i - 1].next_desc = cpu_to_le32(priv->td0_pool_dma);
- priv->apTailTD[0] = priv->apCurrTD[0] = &priv->apTD0Rings[0];
+ priv->tail_td[0] = priv->apCurrTD[0] = &priv->apTD0Rings[0];
return 0;
@@ -777,7 +777,7 @@ static int device_init_td1_ring(struct vnt_private *priv)
if (i > 0)
priv->apTD1Rings[i - 1].next_desc = cpu_to_le32(priv->td1_pool_dma);
- priv->apTailTD[1] = priv->apCurrTD[1] = &priv->apTD1Rings[0];
+ priv->tail_td[1] = priv->apCurrTD[1] = &priv->apTD1Rings[0];
return 0;
@@ -969,7 +969,7 @@ static int device_tx_srv(struct vnt_private *priv, unsigned int idx)
unsigned char byTsr0;
unsigned char byTsr1;
- for (desc = priv->apTailTD[idx]; priv->iTDUsed[idx] > 0; desc = desc->next) {
+ for (desc = priv->tail_td[idx]; priv->iTDUsed[idx] > 0; desc = desc->next) {
if (desc->td0.owner == OWNED_BY_NIC)
break;
if (works++ > 15)
@@ -1007,7 +1007,7 @@ static int device_tx_srv(struct vnt_private *priv, unsigned int idx)
}
}
- priv->apTailTD[idx] = desc;
+ priv->tail_td[idx] = desc;
return works;
}
--
2.34.1
next prev parent reply other threads:[~2023-10-31 5:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 5:34 [PATCH 00/11] Type encoding info dropped from variable and function names in NIC driver part2 Pavan Bobba
2023-10-31 5:34 ` [PATCH 01/11] staging: vt6655: Type encoding info dropped from variable name "qwBSSTimestamp" Pavan Bobba
2023-10-31 5:34 ` [PATCH 02/11] staging: vt6655: Type encoding info dropped from variable name "qwTSFOffset" Pavan Bobba
2023-10-31 5:34 ` [PATCH 03/11] staging: vt6655: Type encoding info dropped from function name "CARDqGetTSFOffset" Pavan Bobba
2023-10-31 5:34 ` [PATCH 04/11] staging: vt6655: Type encoding info dropped from function name "CARDbSetBeaconPeriod" Pavan Bobba
2023-10-31 5:34 ` [PATCH 05/11] staging: vt6655: Type encoding info dropped from variable name "wBeaconInterval" Pavan Bobba
2023-10-31 5:34 ` [PATCH 06/11] staging: vt6655: Type encoding info dropped from variable name "qwNextTBTT" Pavan Bobba
2023-10-31 5:34 ` [PATCH 07/11] staging: vt6655: Type encoding info dropped from function name "CARDqGetNextTBTT" Pavan Bobba
2023-10-31 5:34 ` [PATCH 08/11] staging: vt6655: Type encoding info dropped from function name "CARDbRadioPowerOff" Pavan Bobba
2023-10-31 5:34 ` [PATCH 09/11] staging: vt6655: Type encoding info dropped from function name "CARDvSafeResetTx" Pavan Bobba
2023-10-31 5:34 ` [PATCH 10/11] staging: vt6655: Type encoding info dropped from variable name "pCurrTD" Pavan Bobba
2023-10-31 5:34 ` Pavan Bobba [this message]
2023-11-04 11:39 ` [PATCH 00/11] Type encoding info dropped from variable and function names in NIC driver part2 Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482553f089fe86dc7ebecd96c9397cfaa9c7bdf9.1698730318.git.opensource206@gmail.com \
--to=opensource206@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox