linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: John Reiser <jreiser@BitWagon.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Vegard Nossum <vegard.nossum@gmail.com>,
	Bart Van Assche <bart.vanassche@gmail.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Christoph Lameter <clameter@sgi.com>,
	Daniel Walker <dwalker@mvista.com>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Josh Aune <luken@omner.org>, Pekka Paalanen <pq@iki.fi>
Subject: Re: [ANNOUNCE] kmemcheck v7
Date: Sun, 11 May 2008 00:05:07 +0100	[thread overview]
Message-ID: <48262A23.6030902@goop.org> (raw)
In-Reply-To: <482613B6.2080301@BitWagon.com>

John Reiser wrote:
> The valgrind+uml patches added a callback, "I am switching stacks >NOW<."
>   
Hm, I never particularly liked that approach because unless you do the 
whole thing in assembly it was never certain that there wasn't a 
basic-block break between them (ie, atomic with respect to valgrind).  
For the kernel that may be possible, but I was thinking of the general 
case where you might want to use setjmp or something.

> If possible then it is better to tell an interpreter what is happening,
> rather than requiring that the interpreter [try to] figure it out.
>   

Matter of taste really, but I tend to disagree.  If you say something 
like "addresses A-B, C-D, E-F are stacks", then the stack pointer 
changing from the range A-B to C-D is a pretty clear indication of stack 
switch, regardless of the mechanism you use to do it.  Of course, an 
explicit hint prevents an accidental push/pop of 32k onto an 8K stack 
from being considered a stack switch, but unless you actually know where 
the stacks are, you can't warn about it or prevent it from 
validating/invalidating a pile of innocent memory.

    J

  reply	other threads:[~2008-05-10 23:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-04 13:44 [ANNOUNCE] kmemcheck v7 Vegard Nossum
2008-04-04 13:45 ` [PATCH 1/3] kmemcheck: add the kmemcheck core Vegard Nossum
2008-04-04 13:46 ` [PATCH 2/3] x86: add hooks for kmemcheck Vegard Nossum
2008-04-04 13:47 ` [PATCH 3/3] slub: " Vegard Nossum
2008-05-10  9:07 ` [ANNOUNCE] kmemcheck v7 Bart Van Assche
2008-05-10  9:06   ` Pekka Enberg
2008-05-10 11:04     ` Bart Van Assche
2008-05-10 12:02       ` Vegard Nossum
2008-05-10 12:37         ` Andi Kleen
2008-05-10 13:22           ` Bart Van Assche
2008-05-10 17:17           ` Jeremy Fitzhardinge
2008-05-10 17:48             ` Andi Kleen
2008-05-10 20:45               ` Jeremy Fitzhardinge
2008-05-10 21:29                 ` John Reiser
2008-05-10 23:05                   ` Jeremy Fitzhardinge [this message]
2008-05-10 21:31                 ` Andi Kleen
2008-05-10 22:59                   ` Jeremy Fitzhardinge
2008-05-10 13:29         ` Bart Van Assche
2008-05-10 17:17         ` Jeremy Fitzhardinge
2008-05-10 20:35           ` Jeff Dike
2008-05-11 11:23             ` John Reiser
2008-05-11 12:08         ` John Reiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48262A23.6030902@goop.org \
    --to=jeremy@goop.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=bart.vanassche@gmail.com \
    --cc=clameter@sgi.com \
    --cc=dwalker@mvista.com \
    --cc=jreiser@BitWagon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luken@omner.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=pq@iki.fi \
    --cc=randy.dunlap@oracle.com \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).