From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759756AbcIWMR7 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Sep 2016 08:17:59 -0400
Received: from mout.web.de ([217.72.192.78]:62324 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1759703AbcIWMRy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Sep 2016 08:17:54 -0400
Subject: Re: GPU-DRM-TILCDC: Less function calls in
 tilcdc_convert_slave_node() after error detection
To: Rob Clark <robdclark@gmail.com>
References: <566ABCD9.1060404@users.sourceforge.net>
 <2f3f7ad7-16a0-1dfb-d073-0d993cd767ee@users.sourceforge.net>
 <0be7fee0-64f7-fa02-0337-51376677343e@users.sourceforge.net>
 <e9b443c7-2947-46d5-462f-58c175b774bc@ti.com>
 <d9b20442-3f84-82bd-d600-e3045a21da99@users.sourceforge.net>
 <CAF6AEGsHS9P0XyVH=So9woCkp9u8mUgL1QrCFNzgWdy26_4rDw@mail.gmail.com>
 <3b791118-2977-f607-b816-dd5e833cfc75@users.sourceforge.net>
 <CAF6AEGsh34CNfP6kwGV7nHFfPGp=Vbvja=_6FDuc0XPChJ2Kaw@mail.gmail.com>
Cc: Jyri Sarha <jsarha@ti.com>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Julia Lawall <julia.lawall@lip6.fr>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <48278d51-67b6-2c95-71e4-e922072ad9e9@users.sourceforge.net>
Date: Fri, 23 Sep 2016 14:17:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAF6AEGsh34CNfP6kwGV7nHFfPGp=Vbvja=_6FDuc0XPChJ2Kaw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:YTTBwdf9SxFmqd6DNT3bEUGLVU6K0LPq+u6rSqwMwBvM73FRKh9
 GFrx6kBlpytmCTxro0h3vgl9dluu616Tl87lRSj2ErXmyxisdjLvyugd/GdhT4OLLzheWy4
 8+CffvPKsxecKfXp5TMo0TqXUxGUluepbOxz3lHcy+pkpqsJwuX9Ro49HBR5ETOnDsWcoFL
 Z94ri1yBSut28qJ/6XmJA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Sl3rYa0ye/4=:hSIxcVgfu87DxZdLzDZxwg
 KNYEaDpYaTk3eXTcFWwXAHbF7s9Pyl58A47y7lnkKje3ZxqysdtWjg5OeVRqX1XMStcB9uXRm
 wCXUXYzMcvLZJZbEYThaV7Es+KrMmoLQ0TkGLilXkvz2C1UmPuh/JzAogd7wFsrtUahIjB8RA
 fPQiTpxEEtfgolx3ZMEMpzCydfvsHsqH4Bvq+s/XOK9hahOXORrD+YEQ8WW7ZOGMI8gruEHyF
 2/r3ldcxj4njZ+I5hGONsLqUzPEAtMmz43BV4R8e48fJkMEjHR3QWYW2r/1eKX02de4aDzKGb
 xo3GPRHPwprNaXinHIITlVHW+OIA4s99PLJpGSEFrHJRWXnss6pjWUMu5p9+zrXZbLjmJdgMm
 BayrhxRp+KQEVU4oAvIBeF4l1aiZe6/qJ8Kl6VYvvxrONLkBBLTNr/CrXpZbbc2BB3i4UT8Jd
 MxpD2DMxlp73FVpEg2csMI9WqjQAXYKn90RGl+hH40cJ4YxAFZHAoNaiynfUNR7MRhgK3Zll3
 4vCCRohFdeKPREoqIQ1PFl60XRryVvxlM2jkK8QvVvsgTYEw8MfyMvW/DkxPZi12tcPM3G/c6
 3AIgYQunhU/LQONzGv4niMnuKEXL8eeehiVo1VV3dGBtkh6PWD240MReRj0qDK3Z9u8IthmzJ
 lEGVDRbkD3L0vDpfroZ5gJTolr/ihaygD8er37wQa0l6D392/OTptRPbRoqakM4i64GjGuXYm
 s4cOmTwKm7Aix4zORREY07mTGvdTEUpYAY46dqP3z44vfVQbxKT5CyNp47EnDmTrVnvTQlZ9X
 i4uJKyQ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> I see a need to improve not only correctness there but also a bit of
>> software efficiency.
> 
> If you can measure any performance difference and present some results
> (esp. considering that this is something that just happens when the
> driver is loaded), then we'll talk.

Are you really interested to increase your software development attention
for a quicker exception handling implementation in this function?


> Until then, please don't send this sort of patch.  Thank you.

Will benchmark statistics change such a change rejection ever?

Regards,
Markus