From: Javier Herrero <jherrero@hvsistemas.es>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Bryan Wu <cooloney@kernel.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Bryan Wu <bryan.wu@analog.com>
Subject: Re: [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board
Date: Mon, 12 May 2008 19:31:39 +0200 [thread overview]
Message-ID: <48287EFB.3070303@hvsistemas.es> (raw)
In-Reply-To: <20080512105415.6a8fb88c@core>
Hello, Alan,
Thans, I will redo the patch in the way you suggest, test it and resend.
Regards,
Javier
Alan Cox escribió:
>>
>> +#ifdef SERIAL_EXTRA_IRQ_FLAGS
>> + irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
>> +#endif
>> +
>
>
> We try and keep ifdefs out of code. It is also not clear what you would
> do if you had a box where the extra flags depended on the port.
>
> So two suggestions
>
> Either
>
> Add just the line
>
> + irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
>
> and at the end of 8250.h do
>
> #ifndef SERIAL_EXTRA_IRQ_FLAGS
> #define SERIAL_EXTRA_IRQ_FLAGS 0
> #endif
>
> or the same but with an argument (unused for now)
>
> SERIAL_EXTRA_IRQ_FLAGS(up)
>
> Alan
>
>
--
------------------------------------------------------------------------
Javier Herrero EMAIL: jherrero@hvsistemas.com
HV Sistemas S.L. PHONE: +34 949 336 806
Los Charcones, 17A FAX: +34 949 336 792
19170 El Casar - Guadalajara - Spain WEB: http://www.hvsistemas.com
next prev parent reply other threads:[~2008-05-12 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 4:29 [PATCH 0/2] Try to make 8250 serial work on embedded platform Bryan Wu
2008-05-12 4:29 ` [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board Bryan Wu
2008-05-12 9:54 ` Alan Cox
2008-05-12 17:31 ` Javier Herrero [this message]
2008-05-12 4:29 ` [PATCH 2/2] [Blackfin] serial driver: add extra IRQ flag for 8250 serial driver Bryan Wu
-- strict thread matches above, loose matches on Subject: below --
2008-05-13 4:14 [PATCH 0/2] Add irq extra flags to " Bryan Wu
2008-05-13 4:14 ` [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board Bryan Wu
2008-05-13 9:50 ` Alan Cox
2008-05-13 10:23 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48287EFB.3070303@hvsistemas.es \
--to=jherrero@hvsistemas.es \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bryan.wu@analog.com \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox