* [PATCH 1/1] avr32/pata: avoid unnecessary memset
@ 2008-05-12 21:15 Christophe Jaillet
2008-05-12 22:45 ` HŒaavard Skinnemoen
0 siblings, 1 reply; 2+ messages in thread
From: Christophe Jaillet @ 2008-05-12 21:15 UTC (permalink / raw)
To: cj, linux, hskinnemoen
From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Hi, here is a patch against linux/drivers/dma/iop-adma.c which :
1) Remove an explicit memset(.., 0, ...) to a variable allocated with
kzalloc (i.e. 'info').
Note: this patch is based on 'linux-2.6.25.tar.bz2'
Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
---
--- linux/drivers/ata/pata_at32.c 2008-04-17 04:49:44.000000000 +0200
+++ linux/drivers/ata/pata_at32.c.cj 2008-05-12 23:07:10.000000000 +0200
@@ -329,8 +329,6 @@ static int __init pata_at32_probe(struct
if (!info)
return -ENOMEM;
- memset(info, 0, sizeof(struct at32_ide_info));
-
info->irq = irq;
info->cs = board->cs;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] avr32/pata: avoid unnecessary memset
2008-05-12 21:15 [PATCH 1/1] avr32/pata: avoid unnecessary memset Christophe Jaillet
@ 2008-05-12 22:45 ` HŒaavard Skinnemoen
0 siblings, 0 replies; 2+ messages in thread
From: HŒaavard Skinnemoen @ 2008-05-12 22:45 UTC (permalink / raw)
To: Christophe Jaillet; +Cc: linux, Kristoffer Nyborg Gregertsen, Jeff Garzik
Christophe Jaillet wrote:
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against linux/drivers/dma/iop-adma.c which :
Hmm...no, it's for drivers/ata/pata_at32.c.
> 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
> kzalloc (i.e. 'info').
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Other than that, it looks good to me. Could you please fix the patch
description, add
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
and send it to Jeff?
Thanks a lot!
Haavard
> ---
>
> --- linux/drivers/ata/pata_at32.c 2008-04-17 04:49:44.000000000 +0200
> +++ linux/drivers/ata/pata_at32.c.cj 2008-05-12 23:07:10.000000000 +0200
> @@ -329,8 +329,6 @@ static int __init pata_at32_probe(struct
> if (!info)
> return -ENOMEM;
>
> - memset(info, 0, sizeof(struct at32_ide_info));
> -
> info->irq = irq;
> info->cs = board->cs;
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-12 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-12 21:15 [PATCH 1/1] avr32/pata: avoid unnecessary memset Christophe Jaillet
2008-05-12 22:45 ` HŒaavard Skinnemoen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox