From: "Richard A. Smith" <richard@laptop.org>
To: Andres Salomon <dilinger@queued.net>
Cc: avorontsov@ru.mvista.com,
Andrew Morton <akpm@linux-foundation.org>,
cbou@mail.ru, linux-kernel@vger.kernel.org, dwmw2@infradead.org
Subject: Re: [PATCH] power_supply: add CHARGE_COUNTER property and olpc_battery support for it
Date: Tue, 13 May 2008 10:20:15 -0400 [thread overview]
Message-ID: <4829A39F.7050308@laptop.org> (raw)
In-Reply-To: <20080512214629.443a5999@ephemeral>
Andres Salomon wrote:
> + ec_word = be16_to_cpu(ec_word);
> + val->intval = ec_word * 4167 / 10;
Whats wrong with:
> + val->intval = ((int)ec_word) * 6250 / 15;
Which does not have overflow problems and keeps more precision.
--
Richard Smith <richard@laptop.org>
One Laptop Per Child
next prev parent reply other threads:[~2008-05-13 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 4:34 [PATCH] power_supply: support CHARGE_NOW in OLPC battery Andres Salomon
2008-05-08 10:51 ` Anton Vorontsov
2008-05-08 17:01 ` Andres Salomon
2008-05-08 17:13 ` Anton Vorontsov
2008-05-08 18:53 ` Richard A. Smith
2008-05-08 19:36 ` Anton Vorontsov
2008-05-08 20:44 ` Richard A. Smith
2008-05-13 1:46 ` [PATCH] power_supply: add CHARGE_COUNTER property and olpc_battery support for it Andres Salomon
2008-05-13 8:42 ` Anton Vorontsov
2008-05-13 14:20 ` Richard A. Smith [this message]
2008-05-13 16:23 ` Andres Salomon
2008-05-18 21:46 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4829A39F.7050308@laptop.org \
--to=richard@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=cbou@mail.ru \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox