public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: "Vegard Nossum" <vegard.nossum@gmail.com>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Andreas Herrmann" <andreas.herrmann3@amd.com>,
	"\"S.Çag(lar Onur\"" <caglar@pardus.org.tr>,
	Valdis.Kletnieks@vt.edu, "Matt Mackall" <mpm@selenic.com>,
	linux-kernel@vger.kernel.org, lenb@kernel.org
Subject: Re: [BISECTED] Lots of "rescheduling IPIs" in powertop
Date: Wed, 14 May 2008 08:58:05 +0200	[thread overview]
Message-ID: <482A8D7D.7000208@firstfloor.org> (raw)
In-Reply-To: <20080513210217.59a7ca65@infradead.org>

Arjan van de Ven wrote:

[cc Len]

> On Tue, 13 May 2008 23:19:47 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
> 
>> Ok the CPU reports it doesn't support any C states in MWAIT. If that
>> is correct then it would be correct to not use MWAIT idle and might
>> actually save more power to not use it.
> 
> what does the current SVN powertop say on this cpu?
> 
>> I don't know if that's true or not. Do you have a power meter perhaps?
>> If yes can you measure if there's a difference between mwait=idle /
>> default on your box when it is idle?
>>
>> [cc Arjan he might now if that CPU is supposed to support C1 in MWAIT]
> 
> I wasn't aware that P4's supported mwait in this way; I thought it was
> core and later.

Not even C1? I generally consider MWAIT without C1 to be unusable.

Anyways if C1 doesn't work then it would be correct to not use MWAIT.
> 
>> CPU reports it supports C1/C2/C3. Are you sure there is a difference
>> on that box? The code should have kept using MWAIT because it checks
>> C1. Please double check.
> 
> The check is .. dubious I suspect... 

I don't think so.

> because the cpuid bits are not
> actually the prime source of information, the BIOS is.

Hmmm? What BIOS information are you refering to?

Normally it's my experience that CPUID is more reliable than the BIOS.

> If the bios says mwait is usable, we need to use it with the values IT
> gives us.

At least to my knowledge the ACPI FADT just says what C states are
available, not if they are implemented with MWAIT or using IO ports.

-Andi




  reply	other threads:[~2008-05-14  6:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 20:42 [BISECTED] Lots of "rescheduling IPIs" in powertop Vegard Nossum
2008-05-13 20:54 ` Andi Kleen
2008-05-13 21:09   ` Vegard Nossum
2008-05-13 21:19     ` Andi Kleen
2008-05-14  4:02       ` Arjan van de Ven
2008-05-14  6:58         ` Andi Kleen [this message]
2008-05-14 13:55           ` Arjan van de Ven
2008-05-14 15:21             ` Andi Kleen
2008-05-14  6:00       ` Vegard Nossum
2008-05-14  6:56 ` Ingo Molnar
2008-05-14  7:11   ` Vegard Nossum
2008-05-14  9:09   ` Andreas Herrmann
2008-05-14 11:42     ` Andi Kleen
2008-05-15 16:10       ` Andreas Herrmann
2008-05-16  8:40     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482A8D7D.7000208@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=andreas.herrmann3@amd.com \
    --cc=arjan@infradead.org \
    --cc=caglar@pardus.org.tr \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mpm@selenic.com \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox