From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760641AbYENKwq (ORCPT ); Wed, 14 May 2008 06:52:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754612AbYENKwj (ORCPT ); Wed, 14 May 2008 06:52:39 -0400 Received: from gw.goop.org ([64.81.55.164]:44022 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755144AbYENKwi (ORCPT ); Wed, 14 May 2008 06:52:38 -0400 Message-ID: <482AC467.1060100@goop.org> Date: Wed, 14 May 2008 11:52:23 +0100 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Andi Kleen CC: Andrew Morton , Segher Boessenkool , Robert Hancock , Christian Kujau , LKML , Ingo Molnar , Thomas Gleixner , john stultz Subject: Re: [PATCH] common implementation of iterative div/mod References: <481DF3D8.3010108@shaw.ca> <48217674.8080903@goop.org> <48231959.4050406@goop.org> <20080513234627.30476c20.akpm@linux-foundation.org> <482A95BB.1000001@goop.org> <482AA3BD.1030600@firstfloor.org> <482AB6FC.7020202@goop.org> <482AC3E4.2050200@firstfloor.org> In-Reply-To: <482AC3E4.2050200@firstfloor.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andi Kleen wrote: > Jeremy Fitzhardinge wrote: > >> Andi Kleen wrote: >> >>> You would need to annotate it and have a separate object file for the >>> different sections. Also it would need to be compiled PIC. >>> >>> Inlining is better. >>> >> BTW, I'm seeing the memcpy() in __vdso_gettimeofday() not being inlined. >> > > Hmm works here. What compiler do you use? Normally gcc should > recognize the memcpy is just two constant stores and always inline even with -Os. > It's: jeremy@cosworth:~/hg/xen/paravirt/linux-x86_64$ gcc -v Reading specs from /usr/lib/gcc/x86_64-linux/3.4.4/specs Configured with: ../src/configure -v --enable-languages=c,c++,java,f77,pascal,objc,ada,treelang --prefix=/usr --libexecdir=/usr/lib --with-gxx-include-dir=/usr/include/c++/3.4 --enable-shared --with-system-zlib --enable-nls --without-included-gettext --program-suffix=-3.4 --enable-__cxa_atexit --enable-libstdcxx-allocator=mt --enable-clocale=gnu --enable-libstdcxx-debug --enable-java-gc=boehm --enable-java-awt=gtk --disable-werror x86_64-linux Thread model: posix gcc version 3.4.4 20050314 (prerelease) (Debian 3.4.3-13) I think this is still a supported compiler, isn't it? J