From: Steven Rostedt <srostedt@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: mingo@elte.hu, acme@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2]: ftrace: Remove packed attribute on ftrace_page.
Date: Wed, 14 May 2008 09:10:54 -0400 [thread overview]
Message-ID: <482AE4DE.2050709@redhat.com> (raw)
In-Reply-To: <20080513.220656.213078618.davem@davemloft.net>
David Miller wrote:
> It causes unaligned access traps on platforms like sparc
> (ftrace_page may be marked packed, but once we return
> a dyn_ftrace sub-object from this array to another piece
> of code, the "packed" part of the typing information doesn't
> propagate).
>
> But also, it didn't serve any purpose either. Even if packed,
> on 64-bit or 32-bit, it didn't give us any more dyn_ftrace
> entries per-page.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Steven Rostedt <srostedt@redhat.com>
-- Steve
prev parent reply other threads:[~2008-05-14 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 5:06 [PATCH 1/2]: ftrace: Remove packed attribute on ftrace_page David Miller
2008-05-14 13:10 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482AE4DE.2050709@redhat.com \
--to=srostedt@redhat.com \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox