public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Andreas Herrmann <andreas.herrmann3@amd.com>,
	caglar@pardus.org.tr, Valdis.Kletnieks@vt.edu,
	Matt Mackall <mpm@selenic.com>,
	linux-kernel@vger.kernel.org, lenb@kernel.org
Subject: Re: [BISECTED] Lots of "rescheduling IPIs" in powertop
Date: Wed, 14 May 2008 17:21:07 +0200	[thread overview]
Message-ID: <482B0363.6080700@firstfloor.org> (raw)
In-Reply-To: <20080514065558.41071ca8@infradead.org>

Arjan van de Ven wrote:
> On Wed, 14 May 2008 08:58:05 +0200
>>> If the bios says mwait is usable, we need to use it with the values
>>> IT gives us.
>> At least to my knowledge the ACPI FADT just says what C states are
>> available, not if they are implemented with MWAIT or using IO ports.
> 
> _CST does; which is what the mwait C-state selection code uses.
> 
> (and we've seen quirky systems where C1 mwait didn't work, SMM did
> something wrong or something,

What do you mean with didn't work? And they did not report it in CPUID?
And are they wide spread? I haven't heard of any such problems before.

Even the P4 problem is not really that serious btw.

 because the other OS doesn't seem to use
> it for that, so making it the default is not really an option)

But it has been default for practically forever.   It is strange
if you declare Linux default behavior for years suddenly as "not really
an option"

I think it's a sane default. And MWAIT is a valuable optimization.

I don't think we should stop sanely architected interfaces on the first
BIOS quirk someone reports. I'm sure for nearly every feature there's
some broken BIOS out there that gets it wrong somehow. If we did this in
general soon we couldn't use anything.

-Andi


  reply	other threads:[~2008-05-14 15:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 20:42 [BISECTED] Lots of "rescheduling IPIs" in powertop Vegard Nossum
2008-05-13 20:54 ` Andi Kleen
2008-05-13 21:09   ` Vegard Nossum
2008-05-13 21:19     ` Andi Kleen
2008-05-14  4:02       ` Arjan van de Ven
2008-05-14  6:58         ` Andi Kleen
2008-05-14 13:55           ` Arjan van de Ven
2008-05-14 15:21             ` Andi Kleen [this message]
2008-05-14  6:00       ` Vegard Nossum
2008-05-14  6:56 ` Ingo Molnar
2008-05-14  7:11   ` Vegard Nossum
2008-05-14  9:09   ` Andreas Herrmann
2008-05-14 11:42     ` Andi Kleen
2008-05-15 16:10       ` Andreas Herrmann
2008-05-16  8:40     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482B0363.6080700@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=andreas.herrmann3@amd.com \
    --cc=arjan@infradead.org \
    --cc=caglar@pardus.org.tr \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mpm@selenic.com \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox