Re: [patch 6/8] PNP: replace pnp_resource_table with dynamically allocated resources

Bjorn Helgaas
2008-05-14T23:18:47Z

On Tuesday 13 May 2008 08:42:41 pm Andrew Morton wrote:
> On Mon, 05 May 2008 16:36:36 -0600 Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
> > PNP used to have a fixed-size pnp_resource_table for tracking the
> > resources used by a device. This table often overflowed, so we've
> > had to increase the table size, which wastes memory because most
> > devices have very few resources.
> >
> > This patch replaces the table with a linked list of resources where
> > the entries are allocated on demand.
> >
> > This removes messages like these:
> >
> > pnpacpi: exceeded the max number of IO resources
> > 00:01: too many I/O port resources
> >
> > References:
> >
> > http://bugzilla.kernel.org/show_bug.cgi?id=9535
> > http://bugzilla.kernel.org/show_bug.cgi?id=9740
> > http://lkml.org/lkml/2007/11/30/110
> >
> > This patch also changes the way PNP uses the IORESOURCE_UNSET,
> > IORESOURCE_AUTO, and IORESOURCE_DISABLED flags.
>
> This patch kills my prehistoric dual PIII.
>
> http://userweb.kernel.org/~akpm/p5135912.jpg
> http://userweb.kernel.org/~akpm/config-vmm.txt
> http://userweb.kernel.org/~akpm/dmesg-vmm.txt

Thanks for the report. I think I've fixed the problem. You had
to remove the following three patches:

pnp-replace-pnp_resource_table-with-dynamically-allocated-resources.patch
pnp-remove-ratelimit-on-add-resource-failures.patch
pnp-dont-sort-by-type-in-sys-resources.patch

I'll post a new set of four patches (I added one patch to fix this
problem) to replace those. They should go at the same point in the
series as the three you removed.

Bjorn